feat: Add evaluation details to finally hook stage #1246#1262
feat: Add evaluation details to finally hook stage #1246#1262toddbaert merged 2 commits intoopen-feature:mainfrom chrfwow:Add-evaluation-details-to-finally-hook-stage
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
============================================
+ Coverage 93.51% 93.69% +0.18%
- Complexity 463 464 +1
============================================
Files 43 43
Lines 1110 1110
Branches 89 89
============================================
+ Hits 1038 1040 +2
+ Misses 44 43 -1
+ Partials 28 27 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
toddbaert
requested review from
Kavindu-Dodan,
aepfli,
beeme1mr,
guidobrei,
justinabrahms,
liran2000,
thisthat,
thiyagu06,
toddbaert and
warber
|
|
||
| assertThat(details.getErrorCode()).isEqualTo(ErrorCode.PROVIDER_NOT_READY); | ||
| } | ||
|
|
There was a problem hiding this comment.
Yes, a leftover from a previous PR
There was a problem hiding this comment.
No notes!
Thanks!
Will wait for more reviews since this is an SDK change.
I'll also note that this is technically a breaking change, but I suggest that we mark it otherwise, just as we did in JS since:
- according to our spec,
experimental(hooks are stillexperimental) features are subject to breaking changes - the change is very easy to absorb (just add a parameter which can otherwise be ignored)
- it probably won't impact many hooks (very few use the finally stage (only 1 hook in the contribs is impacted)
|
|
||
| import static org.assertj.core.api.Assertions.assertThatCode; | ||
| import static org.assertj.core.api.Assertions.fail; | ||
| import static org.assertj.core.api.Assertions.*; |
|
Will merge/release this next week unless I hear objections. We'll have to do some manual release notes as well when we do, as we did with JS: https://github.com/open-feature/js-sdk/releases/tag/web-sdk-v1.4.0 See also, same change in .NET: open-feature/dotnet-sdk#335 |
Signed-off-by: christian.lutnik <[email protected]>
|
5 participants
This PR
Add flag evaluation details to finally hook stage
Related Issues
Fixes #1246