Skip to content

Conversation

@brynpickering
Copy link
Member

@brynpickering brynpickering commented Nov 13, 2025

Based on internal discussion, this PR limits the GB model to clustered only, simplifying rules to not mention clustered in filenames unnecessarily. We have to keep the wildcard in compose_network so that input_profile_tech gets the appropriate wildcard entry, but I've constrained the wildcard option to just clustered.

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.GB.yaml.
  • Changes in configuration options are documented in doc/gb-model/configtables/*.csv.
  • OET SPDX license header added to all touched files.
  • Sources of newly added data are documented in doc/gb-model/data_sources.rst.
  • A release note doc/gb-model/release_notes.rst is added.

Copy link
Member

@yerbol-akhmetov yerbol-akhmetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @brynpickering. Thank you for the PR. I have tested it locally. It works fine, though there is issue with load_costs in compose_network. It is due to recent merge from upstream. Now load_costs does not take arguements, but loads processed costs. But it is not related to this PR at all.

@brynpickering brynpickering merged commit 71a0b5d into master Nov 19, 2025
5 of 7 checks passed
@brynpickering brynpickering deleted the fix/gb-model-clustered-only branch November 19, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants