Fix EVP_MD_CTX type definition for LibreSSL#550
Merged
kristelmerilain merged 1 commit intoopen-eid:masterfrom Aug 31, 2023
Merged
Fix EVP_MD_CTX type definition for LibreSSL#550kristelmerilain merged 1 commit intoopen-eid:masterfrom
kristelmerilain merged 1 commit intoopen-eid:masterfrom
Conversation
metsma
requested changes
Aug 15, 2023
Contributor
metsma
left a comment
metsma
left a comment
There was a problem hiding this comment.
Don't expose openssl headers in headers. It will introduce build time dependencies to third party usages
Contributor
Author
OK, this should work, then. |
klemensn
changed the title
metsma
approved these changes
Aug 24, 2023
Contributor
|
Can you please rebase on master. There are fixes for window build issues |
From <openssl/evp.h> aka. EVP_Digest(3), otherwise OpenBSD builds fail:
```
/usr/include/openssl/ossl_typ.h:103:30: error: type alias redefinition with different types ('struct env_md_ctx_st' vs 'struct evp_md_ctx_st')
typedef struct env_md_ctx_st EVP_MD_CTX;
^
/usr/ports/pobj/libdigidocpp-3.16.0/libdigidocpp-3.16.0/src/crypto/Digest.h:59:7: note: previous definition is here
using EVP_MD_CTX = struct evp_md_ctx_st;
```
As metsma@ advised, don't include the OpenSSL header in this header to
so as not to introduce build time dependencies to third party usages.
Signed-off-by: Klemens Nanni <[email protected]>
klemensn
added a commit
to klemensn/libdigidocpp
that referenced
this pull request
Oct 19, 2024
…reSSL The underlying struct was renamed, in LibreSSL 3.8.2: openbsd/src@7d242c1 Follow-up to open-eid#550.
klemensn
added a commit
to klemensn/libdigidocpp
that referenced
this pull request
Oct 19, 2024
…reSSL The underlying struct was renamed, in LibreSSL 3.8.2: openbsd/src@7d242c1 Follow-up to open-eid#550. Signed-off-by: Klemens Nanni <[email protected]>
klemensn
added a commit
to klemensn/libdigidocpp
that referenced
this pull request
Nov 12, 2024
From <openssl/evp.h> aka. EVP_Digest(3), otherwise OpenBSD builds fail:
```
/usr/include/openssl/ossl_typ.h:103:30: error: type alias redefinition with different types ('struct env_md_ctx_st' vs 'struct evp_md_ctx_st')
typedef struct env_md_ctx_st EVP_MD_CTX;
^
/usr/ports/pobj/libdigidocpp-3.16.0/libdigidocpp-3.16.0/src/crypto/Digest.h:59:7: note: previous definition is here
using EVP_MD_CTX = struct evp_md_ctx_st;
```
As metsma@ advised, don't include the OpenSSL header in this header to
so as not to introduce build time dependencies to third party usages.
Signed-off-by: Klemens Nanni <[email protected]>
klemensn
added a commit
to klemensn/libdigidocpp
that referenced
this pull request
Nov 12, 2024
…reSSL The underlying struct was renamed, in LibreSSL 3.8.2: openbsd/src@7d242c1 Follow-up to open-eid#550. Signed-off-by: Klemens Nanni <[email protected]>
klemensn
added a commit
to klemensn/libdigidocpp
that referenced
this pull request
Nov 12, 2024
…reSSL The underlying struct was renamed, in LibreSSL 3.8.2: openbsd/src@7d242c1 Follow-up to open-eid#550. Signed-off-by: Klemens Nanni <[email protected]>
kristelmerilain
pushed a commit
that referenced
this pull request
Dec 2, 2024
…reSSL (#636) The underlying struct was renamed, in LibreSSL 3.8.2: openbsd/src@7d242c1 Follow-up to #550. Signed-off-by: Klemens Nanni <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From <openssl/evp.h> aka. EVP_Digest(3), otherwise OpenBSD builds fail:
As metsma@ advised, don't include the OpenSSL header in this header to
so as not to introduce build time dependencies to third party usages.
Signed-off-by: Klemens Nanni [email protected]