Skip to content

Enable FeatureVectorHook for action tasks #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaegukhyun merged 5 commits into from
Aug 1, 2023
Merged

Enable FeatureVectorHook for action tasks #2408

jaegukhyun merged 5 commits into from
Aug 1, 2023

Conversation

@jaegukhyun
Copy link
Contributor

@jaegukhyun jaegukhyun commented Jul 31, 2023 •
edited
Loading

Summary

Same as title.

How to test

Unit, and integration task will check these changes, since dump_features will always be true for otx eval.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 31, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Jul 31, 2023
@github-actions github-actions bot added the TEST Any changes in tests label Jul 31, 2023
@jaegukhyun jaegukhyun marked this pull request as ready for review August 1, 2023 00:20
@jaegukhyun jaegukhyun requested a review from a team as a code owner August 1, 2023 00:20
sungmanc
sungmanc reviewed Aug 1, 2023
View reviewed changes
sungmanc
sungmanc approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaegukhyun jaegukhyun merged commit a3732dd into open-edge-platform:develop Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sungmanc sungmanc sungmanc approved these changes

@eunwoosh eunwoosh eunwoosh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ALGO Any changes in OTX Algo Tasks implementation DOC Improvements or additions to documentation TEST Any changes in tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaegukhyun @sungmanc @eunwoosh