Remove hacks that were added to work around issues in pycocotools#449
Merged
zhiltsov-max merged 1 commit intoopen-edge-platform:developfrom Jan 10, 2022
IRDonch:remove-pycocotools-hax
Merged
Remove hacks that were added to work around issues in pycocotools#449zhiltsov-max merged 1 commit intoopen-edge-platform:developfrom IRDonch:remove-pycocotools-hax
zhiltsov-max merged 1 commit intoopen-edge-platform:developfrom
IRDonch:remove-pycocotools-hax
Conversation
Author
|
Okay, looks good. I'll close it for now and revive it if/when my patch to pycocotools gets accepted and a new release is published. |
Author
This has now happened! As such, I'm reopening this. |
zhiltsov-max
previously approved these changes
Jan 10, 2022
Contributor
zhiltsov-max
left a comment
zhiltsov-max
left a comment
There was a problem hiding this comment.
It's great news! I feel, many projects have == 2.0.2 in requirements, though. Let's merge after the gitpython problem in the tests is resolved.
Author
|
Looks like someone has already submitted a fix for GitPython: gitpython-developers/GitPython#1394. |
pycocotools 2.0.4 includes changes to the build system that make it possible to downgrade NumPy after installing pycocotools, and therefore: * --no-binary=pycocotools is no longer necessary; * TensorFlow can be installed in the same `pip` invocation as Datumaro. The only hack that remains (that I know of) is the usage of `pycocotools-windows` on Windows, since the `pycocotools` PyPI project still doesn't provide Windows wheels (or any other wheels).
zhiltsov-max
approved these changes
Jan 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore this for now. I'm just making sure that the changes I made in ppwwyyxx/cocoapi#6 do actually resolve the issues for which the workarounds were added.
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.