Open
Conversation
StageGuard
requested changes
Feb 17, 2026
app/shared/ui-settings/src/commonMain/kotlin/ui/settings/tabs/media/source/MediaSourceGroup.kt
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
Pull request overview
本 PR 在“媒体源”设置分组中新增“清除无效媒体源”能力:当存在连接测试结果为 FAILED 的数据源时,可一键确认后批量删除,并通过 Toast 提示成功/失败数量;同时补充了中英繁体等多语言文案。
Changes:
- 在媒体源列表页新增“清除无效源(n)”按钮、确认对话框与删除结果提示
- 在
EditMediaSourceState中新增批量删除方法及删除结果统计结构 - 补充新增功能相关的多语言字符串资源(EN/zh-CN/zh-HK/zh-TW)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/shared/ui-settings/src/commonMain/kotlin/ui/settings/tabs/media/source/MediaSourceGroupState.kt | 增加批量删除逻辑与结果统计,并暴露任务运行状态以供 UI 禁用交互 |
| app/shared/ui-settings/src/commonMain/kotlin/ui/settings/tabs/media/source/MediaSourceGroup.kt | 增加无效源筛选、按钮展示/禁用逻辑、确认弹窗与 Toast 结果提示 |
| app/shared/app-lang/src/androidMain/res/values/strings.xml | 添加英文文案:清除无效源/确认/结果 |
| app/shared/app-lang/src/androidMain/res/values-zh-rCN/strings.xml | 添加简体中文文案:清除无效源/确认/结果 |
| app/shared/app-lang/src/androidMain/res/values-zh-rHK/strings.xml | 添加繁体(香港)文案:清除无效源/确认/结果 |
| app/shared/app-lang/src/androidMain/res/values-zh-rTW/strings.xml | 添加繁体(台湾)文案:清除无效源/确认/结果 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/shared/ui-settings/src/commonMain/kotlin/ui/settings/tabs/media/source/MediaSourceGroup.kt
Outdated
Show resolved
Hide resolved
...red/ui-settings/src/commonMain/kotlin/ui/settings/tabs/media/source/MediaSourceGroupState.kt
Show resolved
Hide resolved
Member
|
删除之后过一会自动更新数据源了是不是又回来了? |
Author
是的,我觉得这么做应该是合理的,或者我们可以在更新订阅的时候自动跑一下检测,然后弹窗提示成功添加多少个订阅,多少个订阅源因失效添加失败 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容:
新增“清除无效媒体源”功能,用于批量删除连接测试结果为 FAILED 的数据源。
当存在无效源,且当前未在测试、编辑或排序状态时,显示“清除无效源(n)”按钮
点击后弹出确认对话框
确认后批量删除,并提示删除成功与失败数量
代码修改:
MediaSourceGroup
新增无效源筛选与按钮显示逻辑
新增批量删除确认对话框
调用批量删除接口并显示结果提示
MediaSourceGroupState
新增 deleteMediaSources 方法及结果统计结构
补充中英文及繁体多语言字符串资源