Open
Conversation
Member
|
建议PR少量多次,好合并 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR internationalizes various scattered parts of the application, replacing hardcoded Chinese strings with localized string resources. The changes cover the home page (for non-logged-in users), search functionality, and incomplete internationalization in the settings pages.
- Internationalized text in settings network and proxy configuration pages
- Added localized strings for account-related UI elements and login/logout functionality
- Implemented internationalization for search page UI elements and NSFW content handling
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ServerSelectionGroup.kt | Replaces hardcoded Chinese strings with internationalized resources for server selection |
| ConfigureProxyGroup.kt | Adds internationalization for proxy configuration UI text and status messages |
| DebugTab.kt | Updates logout functionality to use shared account strings instead of debug-specific ones |
| SelfInfoBanner.kt | Internationalizes login/register button text |
| ProfilePopupLayout.kt | Adds internationalization for profile popup menu items and descriptions |
| BangumiAuthorizeLayout.kt | Internationalizes login/register button in authorization flow |
| NsfwMask.kt | Adds internationalization for NSFW content display controls |
| SelfAvatar.kt | Internationalizes avatar menu items and logout confirmation dialog |
| SearchPageResultColumn.kt | Adds internationalization for search result text and sorting options |
| SearchPage.kt | Internationalizes search page UI elements like placeholder text and navigation |
| SearchFilter.kt | Adds TODO comment for future internationalization of tag filters |
| FollowedSubjectsLazyRow.kt | Internationalizes hint text for empty followed subjects |
| UserInfoRow.kt | Internationalizes settings icon description |
| MainScreen.kt | Internationalizes settings navigation item text |
| strings.xml files | Adds new string resources for all supported locales (en, zh-CN, zh-TW, zh-HK) |
| Tag.kt | Adds TODO comment for future internationalization of tag kinds |
Comments suppressed due to low confidence (1)
app/shared/ui-exploration/src/commonMain/kotlin/ui/exploration/search/SearchPageResultColumn.kt:1
- This import is no longer used after removing the itemKey usage. It should be removed to keep imports clean.
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
app/shared/app-lang/src/androidMain/res/values-zh-rCN/strings.xml
Outdated
Show resolved
Hide resolved
app/shared/ui-exploration/src/commonMain/kotlin/ui/exploration/search/SearchPageResultColumn.kt
Show resolved
Hide resolved
Him188
requested changes
Sep 4, 2025
Member
Him188
left a comment
There was a problem hiding this comment.
请确保简体中文部分与以前完全一致, 其他语言要对应简体中文的措辞方式
app/shared/app-lang/src/androidMain/res/values-zh-rCN/strings.xml
Outdated
Show resolved
Hide resolved
Member
|
有 conflict, 辛苦解决一下? |
Member
Author
已更新 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
该PR仅将部分内容进行国际化,后续有待完善