Skip to content

RFC with enhancements to MultimodalQnA#208

Merged
ashahba merged 38 commits intoopea-project:mainfrom
dmsuehir:dina/mm-rfc
Oct 17, 2024
Merged

RFC with enhancements to MultimodalQnA#208
ashahba merged 38 commits intoopea-project:mainfrom
dmsuehir:dina/mm-rfc

Conversation

@dmsuehir
Copy link
Copy Markdown
Contributor

@dmsuehir dmsuehir commented Oct 16, 2024

This PR adds an RFC which proposes enhancements to the MultimodalQnA megaservice. MultimodalQnA currently supports videos (with or without transcriptions) and text queries. The RFC proposes adding support for images (with or without text) and speech audio files for both queries and for data prep/ingestion.

FYI @tileintel @MSCetin37 @mhbuehler @okhleif-IL @ashahba

dmsuehir and others added 30 commits October 3, 2024 15:26
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
…d some gateway info.

Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
…agram for Gaudi using tgi

Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Language edits and UI alternative
dmsuehir and others added 8 commits October 11, 2024 14:58
Signed-off-by: Dina Suehiro Jones <[email protected]>
* Adds pdf processing details

Signed-off-by: Melanie Buehler <[email protected]>

* Edit title header

Signed-off-by: Melanie Buehler <[email protected]>

---------

Signed-off-by: Melanie Buehler <[email protected]>
* Update compatibility section

Signed-off-by: Dina Suehiro Jones <[email protected]>

* Wording

Signed-off-by: Dina Suehiro Jones <[email protected]>

---------

Signed-off-by: Dina Suehiro Jones <[email protected]>
* added other enhancements

Signed-off-by: okhleif-IL <[email protected]>

* changed wording

* can --> will

Signed-off-by: okhleif-IL <[email protected]>

* addressed rev comments

Signed-off-by: okhleif-IL <[email protected]>

---------

Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: Dina Suehiro Jones <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
@dmsuehir
Copy link
Copy Markdown
Contributor Author

dmsuehir commented Oct 16, 2024

It looks like the relative path hyperlink check is failing because it's assume that the name of my fork is dmsuehir/docs, however I forked it as dmsuehir/opea-project-docs.

So, the URL being checked in the test is incorrect. It's looking for https://github.com/dmsuehir/docs/tree/dina/mm-rfc/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md#data-ingestion-and-prep (which doesn't exist), but the correct link works: https://github.com/dmsuehir/opea-project-docs/blob/dina/mm-rfc/community/rfcs/24-10-02-GenAIExamples-001-Image_and_Audio_Support_in_MultimodalQnA.md#data-ingestion-and-prep

I manually checked the links that are being called out as failing to verify that they work with the corrected URL.

Copy link
Copy Markdown
Collaborator

@ashahba ashahba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants