Merged
Conversation
Instead of first token latency, as that will be available only for queries using streaming mode. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Use more specific req/s + t/s (instead of count/s) for units. Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
Collaborator
Author
|
@poussa Please review. |
lianhao
approved these changes
Mar 6, 2025
poussa
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improvements for app dashboards added in #800 :
Issues
Dashboard did not list anything unless requests were using stream mode. Using pending request metric fixes that.
Type of change
Dependencies
n/a.Tests
Checked manually that Dashboard works fine.