Skip to content

Improve GH workflow updated chart identification#814

Closed
eero-t wants to merge 1 commit intoopea-project:mainfrom
eero-t:chart-pushing
Closed

Improve GH workflow updated chart identification#814
eero-t wants to merge 1 commit intoopea-project:mainfrom
eero-t:chart-pushing

Conversation

@eero-t
Copy link
Copy Markdown
Collaborator

@eero-t eero-t commented Feb 17, 2025

Description

Improve release chart identification for pushing, by:

  • Separating common functionality to its own function
  • Making exclusion matches more explicit:
    • Exclude all files directly in helm-charts/
    • Make exclusion specific to intended filename extensions
    • Exclude non-helm subdirs, instead of files in them (including new assets/ subdir for doc screenshots)

Issues

Current *.md *.sh patterns are not file name extension matches, as * matches any string and . matches any character.

(They work just by luck, because currently none of the other files include "md" nor "sh" in their names...)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a.

Tests

CI.

Notes

This ignores Helm chart docs like earlier code doc did. I do not think that to be correct though, because users can query Helm chart READMEs with helm show readme command, so chart doc not being up to date is a bit of a bug. See: https://helm.sh/docs/helm/helm_show_readme/

@eero-t
Copy link
Copy Markdown
Collaborator Author

eero-t commented Feb 17, 2025

@yongfengdu #800 depends on this.

@lianhao lianhao requested a review from yongfengdu February 18, 2025 00:48
@yongfengdu
Copy link
Copy Markdown
Collaborator

Yes, README.md changes should be updated too.
This also partially fixed #803

@poussa poussa closed this in #800 Feb 18, 2025
@eero-t
Copy link
Copy Markdown
Collaborator Author

eero-t commented Feb 18, 2025

Yes, README.md changes should be updated too. This also partially fixed #803

@yongfengdu I pushed update, but it does not show up here (because @poussa closed this?).

@poussa
Copy link
Copy Markdown
Member

poussa commented Feb 18, 2025

I merged PR#800 and that automatically closed PR#814 (this one) !

@poussa
Copy link
Copy Markdown
Member

poussa commented Feb 18, 2025

re-opening due to auto-close (see below)

@poussa
Copy link
Copy Markdown
Member

poussa commented Feb 18, 2025

hmm, re-opening does not work.

@poussa
Copy link
Copy Markdown
Member

poussa commented Feb 18, 2025

@eero-t I think you need to re-create the PR. Don't what is the issue and why this one was closed automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants