Improve GH workflow updated chart identification#814
Closed
eero-t wants to merge 1 commit intoopea-project:mainfrom
Closed
Improve GH workflow updated chart identification#814eero-t wants to merge 1 commit intoopea-project:mainfrom
eero-t wants to merge 1 commit intoopea-project:mainfrom
Conversation
Signed-off-by: Eero Tamminen <[email protected]>
This was referenced Feb 17, 2025
Collaborator
Author
|
@yongfengdu #800 depends on this. |
yongfengdu
approved these changes
Feb 18, 2025
Collaborator
|
Yes, README.md changes should be updated too. |
Collaborator
Author
@yongfengdu I pushed update, but it does not show up here (because @poussa closed this?). |
Member
|
I merged PR#800 and that automatically closed PR#814 (this one) ! |
Member
|
re-opening due to auto-close (see below) |
Member
|
hmm, re-opening does not work. |
Member
|
@eero-t I think you need to re-create the PR. Don't what is the issue and why this one was closed automatically. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve release chart identification for pushing, by:
helm-charts/assets/subdir for doc screenshots)Issues
Current
*.md*.shpatterns are not file name extension matches, as*matches any string and.matches any character.(They work just by luck, because currently none of the other files include "md" nor "sh" in their names...)
Type of change
Dependencies
n/a.Tests
CI.
Notes
This ignores Helm chart docs like earlier code doc did. I do not think that to be correct though, because users can query Helm chart READMEs with
helm show readmecommand, so chart doc not being up to date is a bit of a bug. See: https://helm.sh/docs/helm/helm_show_readme/