kubeai/readme: improve nri optimization instructions#1119
Merged
poussa merged 3 commits intoopea-project:mainfrom Jul 3, 2025
Merged
kubeai/readme: improve nri optimization instructions#1119poussa merged 3 commits intoopea-project:mainfrom
poussa merged 3 commits intoopea-project:mainfrom
Conversation
Co-authored-by: Malini Bhandaru <[email protected]> Signed-off-by: Markus Lehtonen <[email protected]>
for more information, see https://pre-commit.ci
poussa
approved these changes
Jun 12, 2025
eero-t
reviewed
Jun 12, 2025
| > install the NRI plugin to an empty node (do it right after node bootstrap, or | ||
| > drain the node before installation). | ||
| > **NOTE:** To avoid disturbing already running workloads, it is recommended to | ||
| > install the NRI plugin on an empty node, that is, before deploying workloads |
Collaborator
There was a problem hiding this comment.
Admin does not need to install the plugin on the node itself, but can do it using Kubernetes facilities from outside the node, to install it to the node, right?
Collaborator
Author
There was a problem hiding this comment.
Yeah, maybe that's better, "onto"?
Collaborator
There was a problem hiding this comment.
@marquiz Are you going to update the PR? (I can merge it after that as Sakari has already approved this.)
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Malini Bhandaru [email protected]