Fix shellcheck issues and update secrets TOKEN name#2043
Merged
Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
ZePan110
requested review from
chensuyue,
ftian1,
lkk12014402,
lvliang-intel,
minmin-intel and
rbrugaro
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes the environment variable naming for Hugging Face tokens and adds missing shebangs to shell scripts.
- Switches from
HUGGINGFACEHUB_API_TOKENtoHF_TOKENthroughout compose files - Updates
set_env.shto export the newHF_TOKENvariable - Adds
#!/bin/bashshebangs to top‐level scripts
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| HybridRAG/docker_compose/intel/hpu/gaudi/set_env.sh | Replaces old token exports with HF_TOKEN |
| HybridRAG/docker_compose/intel/hpu/gaudi/compose.yaml | Updates service env keys to use HF_TOKEN |
| .set_env.sh | Adds missing shebang |
| .github/env/_build_image.sh | Adds missing shebang |
Comments suppressed due to low confidence (1)
.set_env.sh:1
- [nitpick] You've added the shebang but may also need to ensure the script has execute permissions (
chmod +x .set_env.sh) so it runs as intended.
#!/bin/bash
chensuyue
approved these changes
Jun 6, 2025
edlee123
pushed a commit
to edlee123/GenAIExamples
that referenced
this pull request
Jun 24, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
alexsin368
pushed a commit
to alexsin368/GenAIExamples
that referenced
this pull request
Aug 13, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix shellcheck issues and update secrets TOKEN name
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.