Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
A concise update to standardize the Hugging Face API token environment variable across DocSum components.
- Renamed all references of
HUGGINGFACEHUB_API_TOKENtoHF_TOKENin documentation and scripts - Updated Docker Compose files to map service-level env vars consistently to
HF_TOKEN - Adjusted AMD GPU setup scripts and READMEs to reflect the new variable name
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| DocSum/tests/README.md | Updated env var instruction to HF_TOKEN |
| DocSum/docker_compose/intel/set_env.sh | Switched export from HUGGINGFACEHUB_API_TOKEN to HF_TOKEN |
| DocSum/docker_compose/intel/hpu/gaudi/compose_tgi.yaml | Updated service env mappings to use HF_TOKEN |
| DocSum/docker_compose/intel/hpu/gaudi/compose.yaml | Updated service env mappings to use HF_TOKEN |
| DocSum/docker_compose/intel/cpu/xeon/compose_tgi.yaml | Updated service env mappings to use HF_TOKEN |
| DocSum/docker_compose/intel/cpu/xeon/compose.yaml | Updated service env mappings to use HF_TOKEN |
| DocSum/docker_compose/amd/gpu/rocm/set_env_vllm.sh | Switched export to DOCSUM_HUGGINGFACEHUB_API_TOKEN=${HF_TOKEN} |
| DocSum/docker_compose/amd/gpu/rocm/set_env.sh | Switched export to DOCSUM_HUGGINGFACEHUB_API_TOKEN=${HF_TOKEN} |
| DocSum/docker_compose/amd/gpu/rocm/README.md | Updated env var instruction to HF_TOKEN |
Comments suppressed due to low confidence (3)
DocSum/docker_compose/intel/hpu/gaudi/compose_tgi.yaml:16
- [nitpick] The environment variable name
HUGGING_FACE_HUB_TOKENdiffers fromHF_TOKENnaming conventions. Consider standardizing onHF_TOKENto keep naming consistent across all services.
HUGGING_FACE_HUB_TOKEN: ${HF_TOKEN}
DocSum/docker_compose/amd/gpu/rocm/set_env_vllm.sh:7
- [nitpick] The variable
DOCSUM_HUGGINGFACEHUB_API_TOKENis quite long compared toHF_TOKEN. Consider renaming it toDOCSUM_HF_TOKENfor clarity and consistency.
export DOCSUM_HUGGINGFACEHUB_API_TOKEN=${HF_TOKEN}
DocSum/docker_compose/intel/hpu/gaudi/compose_tgi.yaml:51
- [nitpick] This duplicates the
HF_TOKENmapping. If the application only consumesHF_TOKEN, you can remove the redundantHUGGINGFACEHUB_API_TOKENentry to simplify the configuration.
HUGGINGFACEHUB_API_TOKEN: ${HF_TOKEN}
Collaborator
Author
|
DocSum test fail on Gaudi is known issue opea-project/GenAIComps#1725 So it can be merged first |
chensuyue
approved these changes
Jun 6, 2025
lvliang-intel
approved these changes
Jun 6, 2025
edlee123
pushed a commit
to edlee123/GenAIExamples
that referenced
this pull request
Jun 24, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
alexsin368
pushed a commit
to alexsin368/GenAIExamples
that referenced
this pull request
Aug 13, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
update secrets token name for DocSum.
Issues
#1954
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.