Conversation
Signed-off-by: ZePan110 <ze.pan@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull Request Overview
The PR standardizes the environment variable name for HuggingFace tokens across scripts, Docker/YAML configs, Helm charts, workflows, and documentation.
- Replaces
HUGGINGFACEHUB_API_TOKENwithHF_TOKENin all test and launch scripts - Updates Docker Compose and Helm chart environment keys to use the new variable
- Adjusts GitHub workflows and README files to reference
HF_TOKENconsistently
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| AgentQnA/tests/*.sh | Updated export of HF_TOKEN in various scripts |
| AgentQnA/retrieval_tool/launch_retrieval_tool.sh | Swapped legacy token var for HF_TOKEN |
| AgentQnA/docker_compose/**/*.{sh,yaml} | Changed environment var references to HF_TOKEN |
| AgentQnA/kubernetes/helm/README.md | Updated Helm install to use HF_TOKEN |
| AgentQnA/README.md | Updated token export example to HF_TOKEN |
| .github/workflows/_run-docker-compose.yml | Swapped secrets to HF_TOKEN |
| .github/workflows/_helm-e2e.yml, _gmc-e2e.yml | Updated workflows to reference HF_TOKEN |
Comments suppressed due to low confidence (5)
.github/workflows/_helm-e2e.yml:169
- The environment variable
HFTOKENlacks the underscore and is inconsistent withHF_TOKENused elsewhere. Rename it toHF_TOKENfor consistency.
HFTOKEN: ${{ secrets.HF_TOKEN }}
.github/workflows/_helm-e2e.yml:193
- Using
${HFTOKEN}here may be broken if the variable was renamed toHF_TOKEN. Update this reference to${HF_TOKEN}.
--set global.HF_TOKEN=${HFTOKEN} \
AgentQnA/docker_compose/intel/hpu/gaudi/compose.yaml:19
- The container key
HUGGINGFACEHUB_API_TOKENremains legacy—consider renaming it toHF_TOKEN(or the app’s expected key) to reflect the new standard.
HUGGINGFACEHUB_API_TOKEN: ${HF_TOKEN}
AgentQnA/docker_compose/amd/gpu/rocm/compose_vllm.yaml:14
- Both
HUGGINGFACEHUB_API_TOKENandHF_TOKENare declared for the same value—remove the legacyHUGGINGFACEHUB_API_TOKENentry to avoid redundancy.
HF_TOKEN: ${HF_TOKEN}
AgentQnA/kubernetes/helm/README.md:7
- The example uses
HFTOKENbut other docs and scripts referenceHF_TOKEN. Update this toexport HF_TOKEN=for consistency.
export HFTOKEN="insert-your-huggingface-token-here"
Signed-off-by: ZePan110 <ze.pan@intel.com>
chensuyue
approved these changes
Jun 4, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
letonghan
approved these changes
Jun 5, 2025
edlee123
pushed a commit
to edlee123/GenAIExamples
that referenced
this pull request
Jun 5, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
edlee123
pushed a commit
to edlee123/GenAIExamples
that referenced
this pull request
Jun 24, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: Ed Lee <16417837+edlee123@users.noreply.github.com>
alexsin368
pushed a commit
to alexsin368/GenAIExamples
that referenced
this pull request
Aug 13, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: alexsin368 <alex.sin@intel.com>
cogniware-devops
pushed a commit
to Cogniware-Inc/GenAIExamples
that referenced
this pull request
Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issues
#1954
#1999
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.