Skip to content

Fix input issue for manual-image-build.yml #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chensuyue merged 2 commits into from
Mar 17, 2025
Merged

Fix input issue for manual-image-build.yml #1666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f441e17
fix input issue for manual-image-build.yml
chensuyue Mar 17, 2025
f430251
fix condition
chensuyue Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/_example-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ on:
type: boolean

jobs:
####################################################################################################
# Image Build
####################################################################################################
pre-build-image-check:
runs-on: ubuntu-latest
outputs:
Expand All @@ -64,9 +67,6 @@ jobs:
echo "should_skip=false" >> $GITHUB_OUTPUT
fi

####################################################################################################
# Image Build
####################################################################################################
build-images:
needs: [pre-build-image-check]
if: ${{ needs.pre-build-image-check.outputs.should_skip == 'false' }}
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
run: |
set -x
run_compose="false"
if [[ ${{ inputs.test_compose }} ]]; then
if [[ "${{ inputs.test_compose }}" == "true" ]]; then
if [[ "${{ needs.pre-build-image-check.outputs.should_skip }}" == "false" && "${{ needs.build-images.result}}" == "success" || "${{ needs.pre-build-image-check.outputs.should_skip }}" == "true" ]]; then
run_compose="true"
fi
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/manual-example-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,12 @@ on:
type: string
inject_commit:
default: false
description: "inject commit to docker images true or false"
description: "inject commit to docker images"
required: false
type: boolean
use_model_cache:
default: false
description: "use model cache true or false"
description: "use model cache"
required: false
type: boolean

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/manual-image-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ on:
type: string
inject_commit:
default: false
description: "inject commit to docker images true or false"
description: "inject commit to docker images"
required: false
type: string
type: boolean

jobs:
get-test-matrix:
Expand Down