Agent ui by WenjiaoYue · Pull Request #1389 · opea-project/GenAIExamples

WenjiaoYue · 2025-01-14T09:21:38Z

Description

Add AgentQnA UI code

Integrate the AgentQnA UI code, along with an updated README specific to the UI, a Dockerfile for deployment, and the necessary startup scripts.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds new functionality)
Breaking change (fix or feature that would break existing design and interface)
Others (enhancement, documentation, validation, etc.)

Dependencies

no

Tests

npm run dev

github-actions · 2025-01-14T09:22:00Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 2 package(s) with unknown licenses.

See the Details below.

License Issues

AgentQnA/ui/svelte/package.json

Package	Version	License	Issue Type
marked	^15.0.0	Null	Unknown License
sjcl	^1.0.8	Null	Unknown License

Scanned Files

AgentQnA/ui/svelte/package.json

AgentQnA/ui/svelte/src/app.html

lkk12014402 · 2025-01-14T10:02:40Z

#1236

The UI is only for the ChatCompletion API and the first version is in the non-streaming form

lkk12014402 · 2025-01-14T10:08:26Z

Please update the ui usage into the readme.

minmin-intel

Why do we choose svelte? It seems that streamlit and gradio are more popular in ecosystem

minmin-intel · 2025-01-14T21:25:17Z

Also, there a couple of warnings for the UI code...Should we address those? @lkk12014402 @WenjiaoYue

WenjiaoYue · 2025-01-15T02:49:25Z

Please update the ui usage into the readme.

Updated UI readme.

WenjiaoYue · 2025-01-15T02:52:35Z

Why do we choose svelte? It seems that streamlit and gradio are more popular in ecosystem
Streamlit and Gradio are both simpler and quicker, but they have limited flexibility and customization capabilities; Svelte is a web development front-end framework, suitable for highly customized web development, offering better extensibility and flexibility for future growth.

WenjiaoYue · 2025-01-15T02:53:09Z

Also, there a couple of warnings for the UI code...Should we address those? @lkk12014402 @WenjiaoYue

Yes, the warning has been resolved.

lkk12014402 · 2025-01-15T03:36:05Z

Why do we choose svelte? It seems that streamlit and gradio are more popular in ecosystem
Streamlit and Gradio are both simpler and quicker, but they have limited flexibility and customization capabilities; Svelte is a web development front-end framework, suitable for highly customized web development, offering better extensibility and flexibility for future growth.

Additionally:

gradio's underlying front-end framework is svelte
all the GenAIExamples use svelte front-end framework

minmin-intel

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

WenjiaoYue · 2025-01-15T06:44:07Z

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

Integrate the AgentQnA UI code, along with an updated README specific to the UI, a Dockerfile for deployment, and the necessary startup scripts. Signed-off-by: WenjiaoYue <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>

minmin-intel · 2025-01-15T17:35:45Z

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

WenjiaoYue · 2025-01-16T03:08:12Z

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

The README of the UI describes two ways to start the frontend: one is by running the local command npm run dev, and the other is by using Docker.

minmin-intel · 2025-01-16T03:25:06Z

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

The README of the UI describes two ways to start the frontend: one is by running the local command npm run dev, and the other is by using Docker.

Thanks for pointing it out. I was looking in the main readme. Can you please add instructions in the main README for UI. Maybe a sentence that links to the README in the UI folder. Thanks! @WenjiaoYue

…nAIExamples into wenjiao/agent_ui

for more information, see https://pre-commit.ci

WenjiaoYue · 2025-01-16T08:25:29Z

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

The README of the UI describes two ways to start the frontend: one is by running the local command npm run dev, and the other is by using Docker.

Thanks for pointing it out. I was looking in the main readme. Can you please add instructions in the main README for UI. Maybe a sentence that links to the README in the UI folder. Thanks! @WenjiaoYue
ok, I have added.

Signed-off-by: WenjiaoYue <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> Co-authored-by: WenjiaoYue <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> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>

Agent ui (opea-project#1389) Signed-off-by: WenjiaoYue <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> Co-authored-by: WenjiaoYue <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> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>

Signed-off-by: WenjiaoYue <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> Co-authored-by: WenjiaoYue <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> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>

WenjiaoYue requested review from lkk12014402 and minmin-intel as code owners January 14, 2025 09:21

github-advanced-security bot found potential problems Jan 14, 2025

View reviewed changes

AgentQnA/ui/svelte/src/app.html Fixed Show fixed Hide fixed

AgentQnA/ui/svelte/src/app.html Fixed Show fixed Hide fixed

lkk12014402 added this to the v1.2 milestone Jan 14, 2025

lkk12014402 approved these changes Jan 14, 2025

View reviewed changes

minmin-intel reviewed Jan 14, 2025

View reviewed changes

minmin-intel reviewed Jan 15, 2025

View reviewed changes

WenjiaoYue force-pushed the wenjiao/agent_ui branch from 1e347c4 to 9a8608c Compare January 15, 2025 07:05

WenjiaoYue requested review from ZePan110 and chensuyue as code owners January 15, 2025 07:05

Add AgentQnA UI code

73b53ee

Integrate the AgentQnA UI code, along with an updated README specific to the UI, a Dockerfile for deployment, and the necessary startup scripts. Signed-off-by: WenjiaoYue <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>

WenjiaoYue force-pushed the wenjiao/agent_ui branch from bfc644a to 73b53ee Compare January 15, 2025 07:53

Merge branch 'main' into wenjiao/agent_ui

eabac55

WenjiaoYue requested a review from minmin-intel January 15, 2025 07:55

ZePan110 approved these changes Jan 15, 2025

View reviewed changes

solve conflict

1b3dc72

WenjiaoYue added 2 commits January 16, 2025 14:25

Add AgentQnA UI instruction in Agent Readme.

ba7e4af

Merge branch 'wenjiao/agent_ui' of https://github.com/opea-project/Ge…

4f52374

…nAIExamples into wenjiao/agent_ui

[pre-commit.ci] auto fixes from pre-commit.com hooks

101f449

for more information, see https://pre-commit.ci

WenjiaoYue and others added 2 commits January 16, 2025 16:25

Merge branch 'main' into wenjiao/agent_ui

24aa52d

update retriever image name

12785f3

lkk12014402 merged commit 3a9a24a into main Jan 16, 2025

lkk12014402 deleted the wenjiao/agent_ui branch January 16, 2025 10:47

yongfengdu mentioned this pull request Jan 17, 2025

Add AgentQnA UI opea-project/GenAIInfra#724

Merged

3 tasks

Conversation

WenjiaoYue commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Type of change

Dependencies

Tests

Uh oh!

github-actions bot commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

License Issues

AgentQnA/ui/svelte/package.json

Scanned Files

Uh oh!

Uh oh!

Uh oh!

lkk12014402 commented Jan 14, 2025

Uh oh!

lkk12014402 commented Jan 14, 2025

Uh oh!

minmin-intel left a comment

Choose a reason for hiding this comment

Uh oh!

minmin-intel commented Jan 14, 2025

Uh oh!

WenjiaoYue commented Jan 15, 2025

Uh oh!

WenjiaoYue commented Jan 15, 2025

Uh oh!

WenjiaoYue commented Jan 15, 2025

Uh oh!

lkk12014402 commented Jan 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

minmin-intel left a comment

Choose a reason for hiding this comment

Uh oh!

WenjiaoYue commented Jan 15, 2025

Uh oh!

minmin-intel commented Jan 15, 2025

Uh oh!

WenjiaoYue commented Jan 16, 2025

Uh oh!

minmin-intel commented Jan 16, 2025

Uh oh!

WenjiaoYue commented Jan 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

WenjiaoYue commented Jan 14, 2025 •

edited

Loading

github-actions bot commented Jan 14, 2025 •

edited

Loading

lkk12014402 commented Jan 15, 2025 •

edited

Loading