remove examples gateway. by lkk12014402 · Pull Request #979 · opea-project/GenAIComps

lkk12014402 · 2024-12-06T02:35:16Z

Description

remove examples gateway after this pr opea-project/GenAIExamples#992 merged

for more information, see https://pre-commit.ci

comps/cores/mega/gateway.py

for more information, see https://pre-commit.ci

dmsuehir · 2024-12-09T23:52:35Z

@lkk12014402 Will the python gateway tests (such as https://github.com/opea-project/GenAIComps/blob/main/tests/cores/mega/test_multimodalqna_gateway.py) be moved to GenAIExamples?

for more information, see https://pre-commit.ci

comps/cores/mega/http_service.py

lkk12014402 · 2024-12-10T07:09:30Z

@lkk12014402 Will the python gateway tests (such as https://github.com/opea-project/GenAIComps/blob/main/tests/cores/mega/test_multimodalqna_gateway.py) be moved to GenAIExamples?

hi, for the multimodalqna test, there is a ut https://github.com/opea-project/GenAIExamples/tree/main/MultimodalQnA/tests in the GenAIExamples

comps/cores/mega/utils.py

dmsuehir · 2024-12-10T17:24:47Z

@lkk12014402 Will the python gateway tests (such as https://github.com/opea-project/GenAIComps/blob/main/tests/cores/mega/test_multimodalqna_gateway.py) be moved to GenAIExamples?

hi, for the multimodalqna test, there is a ut https://github.com/opea-project/GenAIExamples/tree/main/MultimodalQnA/tests in the GenAIExamples

These are .sh script tests in GenAIExamples, but the ones in test_multimodalqna_gateway.py are python unit tests and it is stubbing out the other microservices in order to isolate testing the gateway, which I find pretty useful. I didn't see other python tests in GenAIExamples, so I wasn't sure if moving the .py test file to https://github.com/opea-project/GenAIExamples/tree/main/MultimodalQnA/tests would automatically work or if there would be more work associated with getting GHA to run those python test.

codecov · 2024-12-11T03:04:41Z

Codecov Report

Attention: Patch coverage is 98.80952% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
comps/cores/mega/http_service.py	94.73%	1 Missing ⚠️

Files with missing lines	Coverage Δ
comps/cores/mega/micro_service.py	`80.72% <100.00%> (-2.33%)`	⬇️
comps/cores/mega/utils.py	`42.32% <100.00%> (+19.82%)`	⬆️
comps/cores/mega/http_service.py	`82.22% <94.73%> (+4.44%)`	⬆️

... and 3 files with indirect coverage changes

lkk12014402 · 2024-12-11T03:09:49Z

@lkk12014402 Will the python gateway tests (such as https://github.com/opea-project/GenAIComps/blob/main/tests/cores/mega/test_multimodalqna_gateway.py) be moved to GenAIExamples?

hi, for the multimodalqna test, there is a ut https://github.com/opea-project/GenAIExamples/tree/main/MultimodalQnA/tests in the GenAIExamples

These are .sh script tests in GenAIExamples, but the ones in test_multimodalqna_gateway.py are python unit tests and it is stubbing out the other microservices in order to isolate testing the gateway, which I find pretty useful. I didn't see other python tests in GenAIExamples, so I wasn't sure if moving the .py test file to https://github.com/opea-project/GenAIExamples/tree/main/MultimodalQnA/tests would automatically work or if there would be more work associated with getting GHA to run those python test.

ok, let's move the .py test of multimodalqna in GenAIComps to GenAIExamples

for more information, see https://pre-commit.ci

comps/cores/mega/http_service.py

for more information, see https://pre-commit.ci

* remove examples gateway. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove gateway. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * refine service code. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update http_service.py * remove gateway ut. * remove gateway ut. * fix conflict service name. * Update http_service.py * add handle message ut. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove `multiprocessing.Process` start server code. * fix ut. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove multiprocessing and enhance ut for coverage. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: chen, suyue <suyue.chen@intel.com>

lkk12014402 requested a review from lvliang-intel as a code owner December 6, 2024 02:35

lkk12014402 and others added 2 commits December 6, 2024 02:37

remove examples gateway.

aeae5c5

[pre-commit.ci] auto fixes from pre-commit.com hooks

556f5df

for more information, see https://pre-commit.ci

ftian1 reviewed Dec 6, 2024

View reviewed changes

comps/cores/mega/gateway.py Outdated Show resolved Hide resolved

chensuyue and others added 3 commits December 6, 2024 14:43

Merge branch 'main' into remove_example_gateway

15c7460

remove gateway.

7ce4c8b

[pre-commit.ci] auto fixes from pre-commit.com hooks

84ba13c

for more information, see https://pre-commit.ci

lkk12014402 marked this pull request as draft December 9, 2024 14:48

lkk12014402 and others added 3 commits December 10, 2024 06:49

refine service code.

ade2d92

[pre-commit.ci] auto fixes from pre-commit.com hooks

e691682

for more information, see https://pre-commit.ci

Merge branch 'main' into remove_example_gateway

c34c9aa

lkk12014402 marked this pull request as ready for review December 10, 2024 07:01

ftian1 reviewed Dec 10, 2024

View reviewed changes

comps/cores/mega/http_service.py Outdated Show resolved Hide resolved

ftian1 reviewed Dec 10, 2024

View reviewed changes

comps/cores/mega/utils.py Outdated Show resolved Hide resolved

Update http_service.py

de51d51

Spycsh self-requested a review December 10, 2024 07:12

Spycsh approved these changes Dec 10, 2024

View reviewed changes

lkk12014402 added 2 commits December 10, 2024 08:20

remove gateway ut.

675dcfc

remove gateway ut.

2c5fb29

joshuayao linked an issue Dec 11, 2024 that may be closed by this pull request

[Feature] Move the functionalities of gateway to GenAIExamples #1026

Closed

lkk12014402 and others added 2 commits December 11, 2024 02:44

fix conflict service name.

6e9dfcd

Update http_service.py

f6ebb3d

lkk12014402 and others added 3 commits December 11, 2024 14:13

Merge branch 'main' into remove_example_gateway

8da4cec

add handle message ut.

e5e2d45

[pre-commit.ci] auto fixes from pre-commit.com hooks

83ae2eb

for more information, see https://pre-commit.ci

ftian1 reviewed Dec 11, 2024

View reviewed changes

comps/cores/mega/http_service.py Outdated Show resolved Hide resolved

lkk12014402 and others added 3 commits December 11, 2024 08:53

remove multiprocessing.Process start server code.

1e07acb

fix ut.

6d52585

[pre-commit.ci] auto fixes from pre-commit.com hooks

d1266b1

for more information, see https://pre-commit.ci

lvliang-intel approved these changes Dec 12, 2024

View reviewed changes

lkk12014402 force-pushed the remove_example_gateway branch 2 times, most recently from 47f6228 to d35617e Compare December 12, 2024 15:25

lkk12014402 and others added 2 commits December 12, 2024 15:28

remove multiprocessing and enhance ut for coverage.

d35617e

Merge branch 'main' into remove_example_gateway

28846a2

ftian1 approved these changes Dec 13, 2024

View reviewed changes

lvliang-intel merged commit f5efaf1 into main Dec 13, 2024

lvliang-intel deleted the remove_example_gateway branch December 13, 2024 01:31

lkk12014402 mentioned this pull request Dec 13, 2024

remove examples gateway. opea-project/GenAIExamples#1250

Merged

artem-astafev mentioned this pull request Dec 13, 2024

Added compose example for MultimodalQnA deployment on AMD ROCm systems opea-project/GenAIExamples#1233

Merged

chensuyue mentioned this pull request Dec 18, 2024

[Bug] 2 examples failed with aiohttp.client_exceptions.ContentTypeError in nightly test opea-project/GenAIExamples#1263

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove examples gateway.#979

remove examples gateway.#979
lvliang-intel merged 21 commits intomainfrom
remove_example_gateway

lkk12014402 commented Dec 6, 2024

Uh oh!

Uh oh!

dmsuehir commented Dec 9, 2024

Uh oh!

Uh oh!

lkk12014402 commented Dec 10, 2024 •

edited

Loading

Uh oh!

Uh oh!

dmsuehir commented Dec 10, 2024

Uh oh!

codecov bot commented Dec 11, 2024 •

edited

Loading

Uh oh!

lkk12014402 commented Dec 11, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

lkk12014402 commented Dec 6, 2024

Description

Uh oh!

Uh oh!

dmsuehir commented Dec 9, 2024

Uh oh!

Uh oh!

lkk12014402 commented Dec 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dmsuehir commented Dec 10, 2024

Uh oh!

codecov bot commented Dec 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lkk12014402 commented Dec 11, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lkk12014402 commented Dec 10, 2024 •

edited

Loading

codecov bot commented Dec 11, 2024 •

edited

Loading