fix prometheus invalid metric name#849
Merged
Spycsh merged 2 commits intoopea-project:mainfrom Nov 4, 2024
Merged
Conversation
for more information, see https://pre-commit.ci
letonghan
approved these changes
Nov 4, 2024
lvliang-intel
approved these changes
Nov 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Contributor
|
Thanks for the fix! |
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
* fix * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Minor fix to #845
follow Underscore format that prometheus accepts
ValueError: Invalid metric name: http_requests_inprogress_comps-chat-agent
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
na
Tests
na