Skip to content

fix pydantic BaseModel in/out in dataflow#818

Merged
lvliang-intel merged 3 commits intoopea-project:mainfrom
Spycsh:protocol_in_out
Oct 23, 2024
Merged

fix pydantic BaseModel in/out in dataflow#818
lvliang-intel merged 3 commits intoopea-project:mainfrom
Spycsh:protocol_in_out

Conversation

@Spycsh
Copy link
Copy Markdown
Collaborator

@Spycsh Spycsh commented Oct 23, 2024

Description

fix api protocol in/out in dataflow

Originally only expect a dict in dataflow. Now support pydantic.BaseModel objects (e.g. ChatCompletionRequest)

Issues

opea-project/GenAIExamples#1007

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

add UT

@Spycsh Spycsh requested a review from lvliang-intel as a code owner October 23, 2024 01:59
@Spycsh Spycsh requested a review from XuhuiRen October 23, 2024 02:00
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/mega/orchestrator.py 90.96% <100.00%> (+0.28%) ⬆️

@lvliang-intel lvliang-intel merged commit 02c3dfe into opea-project:main Oct 23, 2024
madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
* fix protocol in/out supported types

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants