missing dollar sign in check script for hyperlinks?#780
Merged
ZePan110 merged 1 commit intoopea-project:mainfrom Oct 10, 2024
Merged
missing dollar sign in check script for hyperlinks?#780ZePan110 merged 1 commit intoopea-project:mainfrom
ZePan110 merged 1 commit intoopea-project:mainfrom
Conversation
Contributor
Author
|
It could be other reasons why the check script exited without printing anything except my readme file: |
lvliang-intel
approved these changes
Oct 10, 2024
ZePan110
approved these changes
Oct 10, 2024
Signed-off-by: Chun Tao <[email protected]>
ZePan110
force-pushed
the
ctao/pr_check
branch
from
3d02394 to
cfc266c
Compare
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
Signed-off-by: Chun Tao <[email protected]>
WenjiaoYue
pushed a commit
that referenced
this pull request
Jul 7, 2025
Signed-off-by: chensuyue <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Possibly missing dollar sign in check script for hyperlinks in pr readmes
Issues
My pr #775 ran into error when checking hyperlinks in README.md, even after removing all "http" keywords
Reason may be the missing dollar sign for the "changed_files" variable.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests
n/a