Add FAQGen gateway in core to support FAQGen Example, Adds FAQGen LLM service#318
Conversation
Codecov ReportAttention: Patch coverage is
|
Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
for more information, see https://pre-commit.ci
Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
for more information, see https://pre-commit.ci
|
Hi @yogeshmpandey , thanks for contribution. This microservice works perfectly. Please check the comments in the |
Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
for more information, see https://pre-commit.ci
|
I am thinking if it's needed to introduce a new FAQGen type under comps/llm folder. the most of code is same with the one in comps/llm/summarization, just prompt_template is different, right? maybe a more appropriate way is to have a unique code with an extra template folder in which it contains many different templates to allow user to setup when starting the LLM docker. |
Hi @ftian1 I did not want to introduce any breaking change to other components hence added a new LLM endpoint, I agree with this approach, the user can choose the specific prompt template defined by the environment variable. These templates can be read from a template file. Option - 2 |
There was a problem hiding this comment.
merge it at first. we will unify the whole LLM instances together in the next release.
PS:we would implement option 1 and 2 together. so either there is a default system prompt when the service is running, or user can override it during generation with user's query.
Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com>
… service (opea-project#318) Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com> Co-authored-by: Sihan Chen <39623753+Spycsh@users.noreply.github.com> Signed-off-by: Daniel Whitenack <whitenack.daniel@gmail.com>
… service (opea-project#318) Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com> Co-authored-by: Sihan Chen <39623753+Spycsh@users.noreply.github.com> Signed-off-by: Berke <berkecanrizai1@gmail.com>
… service (opea-project#318) Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com> Co-authored-by: Sihan Chen <39623753+Spycsh@users.noreply.github.com> Signed-off-by: Berke <berkecanrizai1@gmail.com>
… service (opea-project#318) Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com> Co-authored-by: Sihan Chen <39623753+Spycsh@users.noreply.github.com> Signed-off-by: Berke <berkecanrizai1@gmail.com>
… service (opea-project#318) Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com> Co-authored-by: Sihan Chen <39623753+Spycsh@users.noreply.github.com> Signed-off-by: sharanshirodkar7 <ssharanshirodkar7@gmail.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
… service (opea-project#318) Signed-off-by: Yogesh Pandey <yogesh.pandey@intel.com> Co-authored-by: Sihan Chen <39623753+Spycsh@users.noreply.github.com>
Description
Added components to support FAQGen Example.
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.n/a
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Added tests to the tests folder.