Skip to content

Add Retrieval gateway in core to support IndexRetrivel Megaservice#314

Merged
xuechendi merged 5 commits intoopea-project:mainfrom
xuechendi:retriever_gateway
Aug 19, 2024
Merged

Add Retrieval gateway in core to support IndexRetrivel Megaservice#314
xuechendi merged 5 commits intoopea-project:mainfrom
xuechendi:retriever_gateway

Conversation

@xuechendi
Copy link
Copy Markdown
Collaborator

@xuechendi xuechendi commented Jul 16, 2024

Description

Add a new gateway which returns searched docs

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

No

Tests

TBD

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes missing coverage. Please review.

Files Patch % Lines
comps/cores/mega/gateway.py 19.23% 21 Missing ⚠️
Files Coverage Δ
comps/cores/mega/constants.py 98.18% <100.00%> (+0.03%) ⬆️
comps/cores/mega/gateway.py 22.77% <19.23%> (-0.67%) ⬇️

... and 1 file with indirect coverage changes

This was referenced Jul 16, 2024
Merged
Closed
@chensuyue chensuyue added this to the v0.8 milestone Jul 18, 2024
@chensuyue chensuyue modified the milestones: v0.8, v0.9 Jul 25, 2024
lkk12014402 pushed a commit that referenced this pull request Aug 8, 2024
@jaswanth8888
Chat QNA React UI with conversation history (#314)
b994bc8 
Signed-off-by: jaswanth8888 <karani.jaswanth@gmail.com>
@xuechendi xuechendi linked an issue Aug 15, 2024 that may be closed by this pull request
IndexRetriever Example opea-project/GenAIExamples#415
Closed
xuechendi and others added 4 commits August 16, 2024 16:11
@xuechendi
Add Retrieval gateway
2dc1835 
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
@pre-commit-ci @xuechendi
[pre-commit.ci] auto fixes from pre-commit.com hooks
f0fe3a3 
for more information, see https://pre-commit.ci
@xuechendi
update gateway to latest protocal
21e4b5c 
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
@xuechendi
tested with DocIndexer, rebased gateway is now workable
aa517d2 
Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
@xuechendi
Copy link
Copy Markdown
Collaborator Author

xuechendi commented Aug 16, 2024

@XuhuiRen @lkk12014402 @kevinintel , please help to approve. this PR is rebased to latest with updated API

@xuechendi xuechendi requested a review from minmin-intel August 19, 2024 16:37
minmin-intel
minmin-intel approved these changes Aug 19, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@minmin-intel minmin-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@xuechendi xuechendi merged commit 56daf95 into opea-project:main Aug 19, 2024
srinarayan-srikanthan pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 21, 2024
@xuechendi @pre-commit-ci @srinarayan-srikanthan
Add Retrieval gateway in core to support IndexRetrivel Megaservice (o…
739da3a 
…pea-project#314)

* Add Retrieval gateway

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update gateway to latest protocal

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* tested with DocIndexer, rebased gateway is now workable

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chensuyue pushed a commit that referenced this pull request Aug 21, 2024
@xuechendi @pre-commit-ci @chensuyue
Add Retrieval gateway in core to support IndexRetrivel Megaservice (#314
72b60bb 
)

* Add Retrieval gateway

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update gateway to latest protocal

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* tested with DocIndexer, rebased gateway is now workable

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit 56daf95)
tileintel pushed a commit to siddhivelankar23/GenAIComps that referenced this pull request Aug 22, 2024
@xuechendi @pre-commit-ci @siddhivelankar23
Add Retrieval gateway in core to support IndexRetrivel Megaservice (o…
93babf6 
…pea-project#314)

* Add Retrieval gateway

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update gateway to latest protocal

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* tested with DocIndexer, rebased gateway is now workable

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: siddhivelankar23 <siddhi.velankar@intel.com>
sharanshirodkar7 pushed a commit to predictionguard/pg-GenAIComps that referenced this pull request Sep 3, 2024
@xuechendi @pre-commit-ci @sharanshirodkar7
Add Retrieval gateway in core to support IndexRetrivel Megaservice (o…
f9011ee 
…pea-project#314)

* Add Retrieval gateway

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update gateway to latest protocal

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* tested with DocIndexer, rebased gateway is now workable

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
@xuechendi @pre-commit-ci
Add Retrieval gateway in core to support IndexRetrivel Megaservice (o…
abc84a9 
…pea-project#314)

* Add Retrieval gateway

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update gateway to latest protocal

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* tested with DocIndexer, rebased gateway is now workable

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Chendi.Xue <chendi.xue@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuhuiRen XuhuiRen XuhuiRen approved these changes

@minmin-intel minmin-intel minmin-intel approved these changes

@lvliang-intel lvliang-intel Awaiting requested review from lvliang-intel lvliang-intel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.9

Development

Successfully merging this pull request may close these issues.

IndexRetriever Example

4 participants

@xuechendi @XuhuiRen @minmin-intel @chensuyue