Skip to content

Provide ARCH option for lvm-video-llama image build#1630

Merged
chensuyue merged 2 commits intomainfrom
rm-nv
Apr 29, 2025
Merged

Provide ARCH option for lvm-video-llama image build#1630
chensuyue merged 2 commits intomainfrom
rm-nv

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented Apr 28, 2025 •
edited by chensuyue
Loading

Description

Provide ARCH option for lvm-video-llama image build.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIComps/actions/runs/14722643512/job/41319172649

eero-t
eero-t previously requested changes Apr 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@eero-t eero-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO better than removing the packages, is failing the build if there are such dependencies. Nvidia builds of components like PyTorch are likely to fail on init after their Nvidia deps are gone.

@joshuayao joshuayao added the bug Something isn't working label Apr 29, 2025
@joshuayao joshuayao added this to OPEA Apr 29, 2025
@joshuayao joshuayao moved this to In review in OPEA Apr 29, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 29, 2025
@joshuayao joshuayao added the r1.3 label Apr 29, 2025
@ZePan110
Fix
8521024 
Signed-off-by: ZePan110 <ze.pan@intel.com>
@chensuyue chensuyue changed the title Delete NV related package Provide ARCH option for lvm-video-llama image build Apr 29, 2025
@chensuyue chensuyue dismissed eero-t’s stale review April 29, 2025 03:54

comments resolved.

@chensuyue chensuyue merged commit a40bc4a into main Apr 29, 2025
26 checks passed
@chensuyue chensuyue deleted the rm-nv branch April 29, 2025 03:54
@github-project-automation github-project-automation bot moved this from In review to Done in OPEA Apr 29, 2025
chensuyue pushed a commit that referenced this pull request Apr 29, 2025
@ZePan110 @chensuyue
Provide ARCH option for lvm-video-llama image build (#1630)
13e391c 
Signed-off-by: ZePan110 <ze.pan@intel.com>
(cherry picked from commit a40bc4a)
madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
@ZePan110
Provide ARCH option for lvm-video-llama image build (opea-project#1630)
b86e0b9 
Signed-off-by: ZePan110 <ze.pan@intel.com>
alexsin368 pushed a commit to alexsin368/GenAIComps that referenced this pull request May 15, 2025
@ZePan110 @alexsin368
Provide ARCH option for lvm-video-llama image build (opea-project#1630)
a70201f 
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>
yinghu5 added a commit that referenced this pull request May 16, 2025
@alexsin368 @pre-commit-ci
@yinghu5 @ZePan110 @lvliang-intel @MSCetin37 @RazvanLiviuVarzaru @chensuyue @Spycsh
Agent: add support for remote server (#1644)
fcf7a5a 
* add support for remote server

Signed-off-by: alexsin368 <alex.sin@intel.com>

* add steps to enable remote server

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* remove use_remote_service

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add OpenAI models instructions, fix format of commands

Signed-off-by: alexsin368 <alex.sin@intel.com>

* simplify ChatOpenAI instantiation

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Revert "simplify ChatOpenAI instantiation"

This reverts commit b7c4acf.

* add back check and logic for llm_engine, set openai_key argument

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Provide ARCH option for lvm-video-llama image build (#1630)

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* Add sglang microservice for supporting llama4 model (#1640)

Signed-off-by: Ye, Xinyu <xinyu.ye@intel.com>
Co-authored-by: Lv,Liang1 <liang1.lv@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* Remove invalid codeowner. (#1642)

Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* add support for remote server

Signed-off-by: alexsin368 <alex.sin@intel.com>

* add steps to enable remote server

Signed-off-by: alexsin368 <alex.sin@intel.com>

* remove use_remote_service

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Signed-off-by: alexsin368 <alex.sin@intel.com>

* bug fix for chunk_size and overlap cause error in dataprep ingestion (#1643)

* bug fix for dataingest url

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* add validation function

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* validation update

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update validation function

Signed-off-by: Mustafa <mustafa.cetin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* MariaDB Vector integrations for retriever & dataprep services (#1645)

* Add MariaDB Vector third-party service

MariaDB Vector was introduced since MariaDB Server 11.7

Signed-off-by: Razvan-Liviu Varzaru <razvan@mariadb.org>

* Add retriever MariaDB Vector integration

Signed-off-by: Razvan-Liviu Varzaru <razvan@mariadb.org>

* Add dataprep MariaDB Vector integration

Signed-off-by: Razvan-Liviu Varzaru <razvan@mariadb.org>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix CI failures

- md5 is used for the primary key not as a security hash
- fixed mariadb readme headers

Signed-off-by: Razvan-Liviu Varzaru <razvan@mariadb.org>

---------

Signed-off-by: Razvan-Liviu Varzaru <razvan@mariadb.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* update PR reviewers (#1651)

Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* Expand test matrix, find all tests use 3rd party Dockerfiles (#1676)

* Expand test matrix, find all tests use 3rd party Dockerfiles

Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* fix the typo of README.md Comp (#1679)

Update README.md for first entry of OPEA

Signed-off-by: alexsin368 <alex.sin@intel.com>

* Fix request handle timeout issue (#1687)

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* FEAT: Enable OPEA microservices to start as MCP servers (#1635)

Signed-off-by: alexsin368 <alex.sin@intel.com>

* Fix huggingface_hub API upgrade issue (#1691)

* Fix huggingfacehub API upgrade issue

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* add OpenAI models instructions, fix format of commands

Signed-off-by: alexsin368 <alex.sin@intel.com>

* Fix dataprep opensearch ingest issue (#1697)

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* Fix embedding issue with ArangoDB due to deprecated HuggingFace API (#1694)

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Signed-off-by: alexsin368 <alex.sin@intel.com>

* simplify ChatOpenAI instantiation

Signed-off-by: alexsin368 <alex.sin@intel.com>

* Revert "simplify ChatOpenAI instantiation"

This reverts commit b7c4acf.

Signed-off-by: alexsin368 <alex.sin@intel.com>

* add back check and logic for llm_engine, set openai_key argument

Signed-off-by: alexsin368 <alex.sin@intel.com>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: alexsin368 <alex.sin@intel.com>
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: Ye, Xinyu <xinyu.ye@intel.com>
Signed-off-by: Mustafa <mustafa.cetin@intel.com>
Signed-off-by: Razvan-Liviu Varzaru <razvan@mariadb.org>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Ying Hu <ying.hu@intel.com>
Co-authored-by: ZePan110 <ze.pan@intel.com>
Co-authored-by: Liang Lv <liang1.lv@intel.com>
Co-authored-by: Mustafa <109312699+MSCetin37@users.noreply.github.com>
Co-authored-by: Razvan Liviu Varzaru <45736827+RazvanLiviuVarzaru@users.noreply.github.com>
Co-authored-by: chen, suyue <suyue.chen@intel.com>
Co-authored-by: Spycsh <39623753+Spycsh@users.noreply.github.com>
WenjiaoYue pushed a commit that referenced this pull request Jul 7, 2025
@ZePan110 @chensuyue
Provide ARCH option for lvm-video-llama image build (#1630)
77079dc 
Signed-off-by: ZePan110 <ze.pan@intel.com>
(cherry picked from commit a40bc4a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chensuyue chensuyue chensuyue approved these changes

@lvliang-intel lvliang-intel lvliang-intel approved these changes

@letonghan letonghan Awaiting requested review from letonghan

@XinyuYe-Intel XinyuYe-Intel Awaiting requested review from XinyuYe-Intel

@lkk12014402 lkk12014402 Awaiting requested review from lkk12014402

@XinyaoWa XinyaoWa Awaiting requested review from XinyaoWa

@ftian1 ftian1 Awaiting requested review from ftian1

+1 more reviewer

@eero-t eero-t eero-t left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working r1.3

Projects

OPEA
Status: Done

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

5 participants

@ZePan110 @eero-t @chensuyue @lvliang-intel @joshuayao