Use monotonic clock in tests#1447
Merged
chensuyue merged 2 commits intoopea-project:mainfrom Jun 3, 2025
Merged
Conversation
eero-t
requested review from
chensuyue,
ftian1 and
lvliang-intel
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅ 🚀 New features to boost your workflow:
|
1 task
lvliang-intel
approved these changes
Apr 14, 2025
To avoid problems with clock jumps with AIO test, and make orchestrator test consistent with earlier metrics change: opea-project#1301 Signed-off-by: Eero Tamminen <eero.t.tamminen@intel.com>
eero-t
requested review from
lkk12014402,
minmin-intel and
rbrugaro
as code owners
xiguiw
approved these changes
May 30, 2025
Contributor
Author
|
As this is approved & CI passes, could somebody merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use monotonic clock in tests.
Issues
Monotonic clock usage avoids potential AIO test problem with clock jumps, and makes orchestrator test consistent with earlier metrics change in #1301.
Type of change
Dependencies
n/aTests
CI.
Related PRs
Base statistics test clock usage is updated as part of #1107.