Skip to content

Fix metric id issue when initializing multiple Orchestrator instances #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lvliang-intel merged 1 commit into from
Feb 12, 2025
Merged

Fix metric id issue when initializing multiple Orchestrator instances #1280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions comps/cores/mega/orchestrator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@


class OrchestratorMetrics:
# Need an instance ID for metric prefix because:
# - Orchestror instances are not named
# - CI creates several orchestrator instances
# Need an static class-level ID for metric prefix because:
# - Prometheus requires metrics (their names) to be unique
_instance_id = 0

def __init__(self) -> None:
self._instance_id += 1
if self._instance_id > 1:
OrchestratorMetrics._instance_id += 1
if OrchestratorMetrics._instance_id > 1:
self._prefix = f"megaservice{self._instance_id}"
else:
self._prefix = "megaservice"
Expand Down