Skip to content

Fix CD workflow type error#1181

Merged
chensuyue merged 1 commit intomainfrom
fix
Jan 21, 2025
Merged

Fix CD workflow type error#1181
chensuyue merged 1 commit intomainfrom
fix

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented Jan 21, 2025

Description

  1. Fix CD workflow type error.
  2. Change dockerhub default value and add the judgment that matrix is not empty to fix workflow errors.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Test case: asr (gaudi, xeon)
Link: https://github.com/opea-project/GenAIComps/actions/runs/12878718143
Status: passed

@ZePan110 ZePan110 requested a review from chensuyue as a code owner January 21, 2025 01:41
@ZePan110 ZePan110 force-pushed the fix branch 3 times, most recently from 046f03d to f3a826a Compare January 21, 2025 02:03
@ZePan110
Copy link
Copy Markdown
Collaborator Author

ZePan110 commented Jan 21, 2025

Test case: asr (gaudi, xeon) with helm charts
Link: https://github.com/opea-project/GenAIComps/actions/runs/12878718143
Status: passed

@chensuyue chensuyue merged commit bfe63e6 into main Jan 21, 2025
@chensuyue chensuyue deleted the fix branch January 21, 2025 03:14
smguggen pushed a commit to opea-aws-proserve/GenAIComps that referenced this pull request Jan 23, 2025
1. Fix CD workflow type error.
2. Change dockerhub default value and add the judgment that matrix is not empty to fix workflow errors.

Signed-off-by: ZePan110 <[email protected]>
madison-evans pushed a commit to SAPD-Intel/GenAIComps that referenced this pull request May 12, 2025
1. Fix CD workflow type error.
2. Change dockerhub default value and add the judgment that matrix is not empty to fix workflow errors.

Signed-off-by: ZePan110 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants