Enable AWS access when testing microservices#1165
Merged
mkbhanda merged 2 commits intoopea-project:mainfrom Jan 17, 2025
Merged
Enable AWS access when testing microservices#1165mkbhanda merged 2 commits intoopea-project:mainfrom
mkbhanda merged 2 commits intoopea-project:mainfrom
Conversation
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
4 tasks
ZePan110
approved these changes
Jan 17, 2025
chensuyue
approved these changes
Jan 17, 2025
Collaborator
chensuyue
left a comment
chensuyue
left a comment
There was a problem hiding this comment.
LGTM, how about other secrets for the test, is this one enough?
smguggen
pushed a commit
to opea-aws-proserve/GenAIComps
that referenced
this pull request
Jan 23, 2025
Signed-off-by: Jonathan Minkin <minkinj@amazon.com> Add id-token permissions for workflow Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
madison-evans
pushed a commit
to SAPD-Intel/GenAIComps
that referenced
this pull request
May 12, 2025
Signed-off-by: Jonathan Minkin <minkinj@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When testing microservices that use AWS, it is required to retrieve AWS credentials as part of the Github Action. This PR modifies the Github Action to include that step.
Issues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Relies on the configure-aws-credentials Github Action
Tests
Created a test action in a private repository.