PR: windows bug fix (issue 14,15, 27) #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rackliu
pushed a commit
to rackliu/Claudable
that referenced
this pull request
Nov 5, 2025
PR: windows bug fix (issue 14,15, 27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: web app now functions properly on windows platform, however codex still has issues due to powershell adaptation.
more specifically:
apps/api/app/services/cli/adapters/claude_code.py
Writes full system prompt to a temp .json (merging existing .claude/settings.json).
CLI points at the temp file, trimming prompt only if the write fails.
Cleans up the temp file at session close → fixes Windows command-length limits while preserving instructions.
apps/api/app/services/cli/manager.py
Added _attempt_fallback: if a CLI (e.g., Codex) is missing/errors, request is routed to Claude automatically.
Response payload now:
Flags when fallback happened.
Carries files_modified metadata so downstream commit logic knows edits occurred.
apps/web/app/[project_id]/chat/page.tsx
Removed behavior of stopping preview server during long tasks.
Auto-starts preview when job queue is idle & iframe isn’t already loading → no more dead localhost loads.
apps/api/app/services/cli/adapters/codex_cli.py
Overhauled Codex adapter:
Locates codex in typical Windows npm folders, adjusts PATH.
Builds correct cmd.exe /c invocation.
Bumps max-turn/think limits.
Rewrites auto-instructions to target Next.js app/page.tsx explicitly.
Patch events now include changes_made + per-file metadata.
Reuses resolved executable in availability checks.
Impact
web app functionality clash with windows OS is solved