Skip to content

Conversation

@emhane
Copy link
Member

@emhane emhane commented Nov 25, 2025

Closes #266

This is the layout
Screenshot 2025-11-25 at 13 24 33

Copilot AI review requested due to automatic review settings November 25, 2025 12:25
@emhane emhane requested a review from theochap November 25, 2025 12:25
@github-actions github-actions bot added A-block-building Area: payload building A-execution Area: EVM & execution K-observability Kind: observability M-good-first-issue Meta: good issue for first time contributors labels Nov 25, 2025
@emhane emhane removed M-good-first-issue Meta: good issue for first time contributors A-execution Area: EVM & execution labels Nov 25, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Grafana panel to track flashblock sequence lengths and upgrades the dashboard to Grafana version 12.2.1 (from 11.5.0).

  • Adds a new "Payload Builder" section with a "Flashblock Sequence Length" panel showing quantile-based metrics (min, p50, p90, p95, p99)
  • Updates Grafana version from 11.5.0 to 12.2.1 with corresponding schema version upgrade from 40 to 42
  • Modernizes panel configurations by replacing null values with 0 and adding showValues: false settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"transactions",
"txpool"
],
"schemaVersion": 42,
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The dashboard tags field was removed entirely. Consider keeping the tags field (even if empty, e.g., "tags": []) for consistency with other dashboards like overview.json (line 11808) which uses the same schema version 42. The removed tags were: "optimism", "rpc", "sequencer", "miner", "transactions", "txpool". If these tags are still relevant for dashboard categorization and searchability in Grafana, they should be preserved.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@op-will op-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emhane emhane added this pull request to the merge queue Nov 25, 2025
Merged via the queue into unstable with commit c221f03 Nov 25, 2025
45 checks passed
@emhane emhane deleted the metric/flashblocks branch November 25, 2025 18:22
emhane added a commit that referenced this pull request Dec 8, 2025
Closes #266

This is the layout
<img width="1578" height="680" alt="Screenshot 2025-11-25 at 13 24 33"
src="https://github.com/user-attachments/assets/59ed27b1-d8c6-4f8d-86ac-953516ea9175"
/>

---------

Co-authored-by: Copilot <[email protected]>
emhane added a commit that referenced this pull request Dec 10, 2025
Closes #266

This is the layout
<img width="1578" height="680" alt="Screenshot 2025-11-25 at 13 24 33"
src="https://github.com/user-attachments/assets/59ed27b1-d8c6-4f8d-86ac-953516ea9175"
/>

---------

Co-authored-by: Copilot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-block-building Area: payload building K-observability Kind: observability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add panel for flashblocks metric

3 participants