chore(deps): Rm redundant dep #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
requested review from
dhyaniarun1993,
itschaindev and
sadiq1971
as code owners
There was a problem hiding this comment.
Pull Request Overview
Removes the redundant reth-db-api dependency in favor of using the DatabaseError re-export from reth-db within the optimism trie crate.
- Replace imports of DatabaseError from reth_db_api with reth_db::DatabaseError
- Remove reth-db-api from Cargo.toml dependencies
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/optimism/trie/src/proof.rs | Switches import to reth_db::DatabaseError to use re-export. |
| crates/optimism/trie/src/api.rs | Switches import to reth_db::DatabaseError to use re-export. |
| crates/optimism/trie/Cargo.toml | Removes the redundant reth-db-api dependency. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
meyer9
approved these changes
Oct 17, 2025
emhane
added a commit
that referenced
this pull request
Oct 20, 2025
Ref #205 Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since used types are re-exported via `reth-db` --------- Co-authored-by: Arun Dhyani <[email protected]>
meyer9
pushed a commit
that referenced
this pull request
Oct 31, 2025
Ref #205 Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since used types are re-exported via `reth-db` --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
added a commit
that referenced
this pull request
Nov 11, 2025
Ref #205 Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since used types are re-exported via `reth-db` --------- Co-authored-by: Arun Dhyani <[email protected]>
meyer9
pushed a commit
that referenced
this pull request
Nov 13, 2025
Ref #205 Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since used types are re-exported via `reth-db` --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
added a commit
that referenced
this pull request
Nov 18, 2025
Ref #205 Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since used types are re-exported via `reth-db` --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
added a commit
that referenced
this pull request
Nov 25, 2025
Ref #205 Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since used types are re-exported via `reth-db` --------- Co-authored-by: Arun Dhyani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #205
Removes redundant dep
reth-db-apifromreth-optimism-trie, since used types are re-exported viareth-db