feat(MDBX): Implement earliest and latest block tracking in storage #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varun-doshi
requested review from
dhyaniarun1993,
emhane,
itschaindev,
meyer9 and
sadiq1971
as code owners
meyer9
reviewed
Oct 16, 2025
Collaborator
meyer9
left a comment
meyer9
left a comment
There was a problem hiding this comment.
LG! Just a small comment
crates/optimism/trie/src/db/store.rs
Outdated
Comment on lines
103
to
107
| self.get_block_number_hash(ProofWindowKey::EarliestBlock).await | ||
| } | ||
|
|
||
| async fn get_latest_block_number(&self) -> OpProofsStorageResult<Option<(u64, B256)>> { | ||
| unimplemented!() | ||
| self.get_block_number_hash(ProofWindowKey::LatestBlock).await |
Collaborator
There was a problem hiding this comment.
For these, can they fall back to the other if it doesn't exist? For example, if there's no latest block, but there is an earliest block, the earliest block is the latest block.
Collaborator
There was a problem hiding this comment.
Yep, sounds good. I have updated the code.
meyer9
added
K-feature
dhyaniarun1993
approved these changes
Oct 17, 2025
emhane
approved these changes
Oct 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
Seems like |
emhane
pushed a commit
that referenced
this pull request
Oct 20, 2025
…253) Fixes #215 --------- Co-authored-by: Arun Dhyani <[email protected]>
meyer9
pushed a commit
that referenced
this pull request
Oct 31, 2025
…253) Fixes #215 --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Nov 11, 2025
…253) Fixes #215 --------- Co-authored-by: Arun Dhyani <[email protected]>
meyer9
pushed a commit
that referenced
this pull request
Nov 13, 2025
…253) Fixes #215 --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Nov 18, 2025
…253) Fixes #215 --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Nov 25, 2025
…253) Fixes #215 --------- Co-authored-by: Arun Dhyani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #215