-
Notifications
You must be signed in to change notification settings - Fork 7
fix(deps): Optionally enable op feature for reth-optimism-primitives
#242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes dependency management for the reth-optimism-primitives crate by introducing an optional op feature. The changes ensure consistent feature enablement across the codebase when working with Optimism-specific functionality.
- Introduced a new
opfeature toreth-optimism-primitivescrate - Updated dependency declarations to optionally enable the
opfeature where needed - Added feature guards to implementation code to prevent compilation issues when the feature is disabled
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/optimism/primitives/Cargo.toml | Adds new op feature and updates dependency specifications |
| crates/optimism/primitives/src/lib.rs | Adds feature guard for NodePrimitives implementation |
| crates/storage/db-api/Cargo.toml | Updates feature dependency to optionally enable op feature |
| crates/rpc/rpc-convert/Cargo.toml | Updates feature dependency to optionally enable op feature |
| crates/optimism/node/Cargo.toml | Removes hardcoded reth-codec feature dependency |
| crates/optimism/evm/Cargo.toml | Explicitly enables op feature for required dependencies |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
realised that |
|
closing in favour or #250 |
Closes #241
The
opfeature exists in reth to be able to implement traits defined in reth onop-alloytypes. The intermediary trie nodes store doesn't use thoseop-alloy-types, it operates on hashed dataRef paradigmxyz#19018