Skip to content

Conversation

@emhane
Copy link
Member

@emhane emhane commented Oct 15, 2025

Closes #241

The op feature exists in reth to be able to implement traits defined in reth on op-alloy types. The intermediary trie nodes store doesn't use those op-alloy-types, it operates on hashed data

Ref paradigmxyz#19018

@emhane emhane added the K-bug Kind: 🐛 label Oct 15, 2025
@emhane emhane added the A-ci Area: CI label Oct 15, 2025
Copilot AI review requested due to automatic review settings October 15, 2025 17:02
@emhane emhane added A-deps Area: dependencies W-historical-proofs Workstream: historical-proofs labels Oct 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes dependency management for the reth-optimism-primitives crate by introducing an optional op feature. The changes ensure consistent feature enablement across the codebase when working with Optimism-specific functionality.

  • Introduced a new op feature to reth-optimism-primitives crate
  • Updated dependency declarations to optionally enable the op feature where needed
  • Added feature guards to implementation code to prevent compilation issues when the feature is disabled

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crates/optimism/primitives/Cargo.toml Adds new op feature and updates dependency specifications
crates/optimism/primitives/src/lib.rs Adds feature guard for NodePrimitives implementation
crates/storage/db-api/Cargo.toml Updates feature dependency to optionally enable op feature
crates/rpc/rpc-convert/Cargo.toml Updates feature dependency to optionally enable op feature
crates/optimism/node/Cargo.toml Removes hardcoded reth-codec feature dependency
crates/optimism/evm/Cargo.toml Explicitly enables op feature for required dependencies

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@emhane
Copy link
Member Author

emhane commented Oct 16, 2025

realised that TrieUpdates need serde-bincode-compat sometimes...so does reth-exex indirectly via reth-exex-types. so I'm adding the feature to reth-trie too, meaning this pr will take a wee bit longer ... @dhyaniarun1993

@emhane
Copy link
Member Author

emhane commented Oct 16, 2025

closing in favour or #250

@emhane emhane closed this Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: CI A-deps Area: dependencies K-bug Kind: 🐛 W-historical-proofs Workstream: historical-proofs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix op feature propagation

3 participants