feat: add storage interface with pruning methods #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyer9
force-pushed
the
meyer9/165-add-empty-exex-crate
branch
from
a24510a to
e1801e2
Compare
meyer9
force-pushed
the
meyer9/166-finalize-storage-interface
branch
from
691fff9 to
9dc8078
Compare
meyer9
force-pushed
the
meyer9/165-add-empty-exex-crate
branch
from
e1801e2 to
d728795
Compare
meyer9
force-pushed
the
meyer9/166-finalize-storage-interface
branch
4 times, most recently
from
6089737 to
3e311c7
Compare
meyer9
force-pushed
the
meyer9/166-finalize-storage-interface
branch
2 times, most recently
from
5ef8999 to
84c813c
Compare
meyer9
force-pushed
the
meyer9/165-add-empty-exex-crate
branch
from
d728795 to
b5d8c02
Compare
meyer9
requested review from
BioMark3r,
dhyaniarun1993,
emhane,
itschaindev,
sadiq1971 and
theochap
as code owners
Base automatically changed from
meyer9/165-add-empty-exex-crate
to
unstable
September 30, 2025 10:29
meyer9
force-pushed
the
meyer9/166-finalize-storage-interface
branch
from
84c813c to
9ca3987
Compare
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a storage interface with pruning and reorganization methods to support external proof generation. The interface defines traits for cursor-based operations and atomic storage transactions.
- Adds comprehensive storage traits for external proof data management
- Implements cursor-based iteration for trie nodes and hashed entries
- Provides atomic methods for pruning, reorganization, and bulk operations
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/exex/external-proofs/src/storage.rs | New storage interface with traits for cursors and external storage operations |
| crates/exex/external-proofs/src/lib.rs | Adds storage module declaration |
| crates/exex/external-proofs/Cargo.toml | Adds required dependencies for the storage interface |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| leaves_diff: HashedPostState, | ||
| ) -> ExternalStorageResult<()>; | ||
|
|
||
| /// Deletes all updates > `latest_common_block_number` and |
There was a problem hiding this comment.
Incomplete documentation comment. The comment ends with 'and' but doesn't specify what happens after deletion.
Suggested change
| /// Deletes all updates > `latest_common_block_number` and | |
| /// Deletes all updates greater than `latest_common_block_number` and replaces them by adding the provided `blocks_to_add`. |
Comment on lines
10
to
12
| pub enum ExternalStorageError { | ||
| Other(eyre::Error), | ||
| } |
Collaborator
There was a problem hiding this comment.
Can we use thiserror for easier error definition?
Suggested change
| pub enum ExternalStorageError { | |
| Other(eyre::Error), | |
| } | |
| #[derive(Debug, Error)] | |
| pub enum ExternalStorageError { | |
| #[error("Other error: {0}")] | |
| Other(eyre::Error), | |
| } |
emhane
approved these changes
Oct 9, 2025
Member
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
lgtm, smol comment. pending @dhyaniarun1993
|
|
||
| /// Error type for storage operations | ||
| pub enum ExternalStorageError { | ||
| Other(eyre::Error), |
Member
There was a problem hiding this comment.
pls add a todo comment that this is just a placeholder
emhane
reviewed
Oct 9, 2025
| @@ -0,0 +1,164 @@ | |||
| #![allow(dead_code, unreachable_pub)] | |||
Member
There was a problem hiding this comment.
Suggested change
| #![allow(dead_code, unreachable_pub)] | |
| #![expect(dead_code, unreachable_pub)] |
use expect instead of allow
emhane
requested changes
Oct 9, 2025
Member
emhane
left a comment
emhane
left a comment
There was a problem hiding this comment.
let's rename ExternalProofs to OpProofs or OpProofsWindow or OpFPPreimages everywhere for better higher level naming of what we're implementing. i think OpProofs is the most suitable for sake of being short.
| use std::fmt::Debug; | ||
|
|
||
| /// Error type for storage operations | ||
| pub enum ExternalStorageError { |
Member
There was a problem hiding this comment.
Suggested change
| pub enum ExternalStorageError { | |
| pub enum OpProofsWindowStorageError { |
let's rename this, alt to OpProofsStorage
Collaborator
Author
There was a problem hiding this comment.
I'll do this on a PR on top of this stack to reduce merge conflicts!
Member
|
OpProofs or OpFPWindow |
meyer9
force-pushed
the
meyer9/166-finalize-storage-interface
branch
from
c5ab8a4 to
49d51e1
Compare
dhyaniarun1993
approved these changes
Oct 9, 2025
emhane
approved these changes
Oct 10, 2025
emhane
pushed a commit
that referenced
this pull request
Oct 20, 2025
Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <[email protected]>
meyer9
added a commit
that referenced
this pull request
Oct 31, 2025
Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Nov 11, 2025
Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <[email protected]>
meyer9
added a commit
that referenced
this pull request
Nov 13, 2025
Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Nov 18, 2025
Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Nov 25, 2025
Fixes #177 I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state. --------- Co-authored-by: Arun Dhyani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177
I added a few methods that should allow atomically pruning and reorging blocks. Each function should represent a single transaction. We can store trie nodes, reorg, prune in a single transaction now. I kept the bulk insert methods available for storing the current state.