forked from paradigmxyz/reth
-
Notifications
You must be signed in to change notification settings - Fork 7
Closed
Labels
A-trieArea: Merkle Patricia TrieArea: Merkle Patricia TrieK-debtKind: debtKind: debtM-good-first-issueMeta: good issue for first time contributorsMeta: good issue for first time contributorsW-historical-proofsWorkstream: historical-proofsWorkstream: historical-proofs
Description
Describe the feature
Make this a wrapper of alloy_eips::BlockNumHash instead
op-reth/crates/optimism/trie/src/db/models/block.rs
Lines 10 to 14 in 0cf732f
| /// Wrapper for block number and block hash tuple to implement [`Compress`]/[`Decompress`]. | |
| /// | |
| /// Used for storing block metadata (number + hash). | |
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize, From, Into, Constructor)] | |
| pub struct BlockNumberHash(pub u64, pub B256); |
Additional context
alloy-eips is already a dependency of reth-optimism-trie indirectly via reth-trie which depends on alloy-consensus, alloy-consensus depends on alloy-eips, so we might as well use the nice existing type from alloy-eips
Metadata
Metadata
Assignees
Labels
A-trieArea: Merkle Patricia TrieArea: Merkle Patricia TrieK-debtKind: debtKind: debtM-good-first-issueMeta: good issue for first time contributorsMeta: good issue for first time contributorsW-historical-proofsWorkstream: historical-proofsWorkstream: historical-proofs
Type
Projects
Status
Done