Add _resolve_time_grain to validate/resolve time_grain (handles "auto").#1204
Open
aagbsn wants to merge 2 commits into
Open
Add _resolve_time_grain to validate/resolve time_grain (handles "auto").#1204aagbsn wants to merge 2 commits into
aagbsn wants to merge 2 commits into
Conversation
Refactor group_by_date and add where_by_date to not repeat Make WHERE use gmap functions (e.g. toDate, toStartOfHour) on both column and params so ClickHouse aggregate projection can match. Replace raw measurement_start_time >= / < clauses with where_by_date call and preserve :since/:until params._
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor group_by_date and add where_by_date to not repeat code
Make WHERE use gmap functions (e.g. toDate, toStartOfHour) on both column and params so ClickHouse aggregate projection can match.
Replace raw measurement_start_time >= / < clauses with where_by_date call and preserve :since/:until params._