Skip to content

Fix stopping strings for llama-3 and phi#6043

Merged
oobabooga merged 4 commits intodevfrom
eot
May 22, 2024
Merged

Fix stopping strings for llama-3 and phi#6043
oobabooga merged 4 commits intodevfrom
eot

Conversation

@oobabooga
Copy link
Copy Markdown
Owner

@oobabooga oobabooga commented May 22, 2024

People who train models are very creative in trying to make their jinja templates as hard to work with as possible. This is an attempt at getting the stopping strings right.

@oobabooga oobabooga merged commit 5499bc9 into dev May 22, 2024
@BadisG
Copy link
Copy Markdown
Contributor

BadisG commented May 22, 2024

The chat doesn't work anymore, the model doesn't want to output anything. I reverted back to the latest dev commit 8aaa0a6 and it works now.

oobabooga added a commit that referenced this pull request May 23, 2024
@oobabooga
Copy link
Copy Markdown
Owner Author

Yeah that wasn't a good solution. I have reverted it and am trying to think of a better way to reverse-engineer those jinja templates. ad54d52

@oobabooga oobabooga deleted the eot branch June 24, 2024 05:36
PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Oct 22, 2024
PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants