Remove tiktoken from logit bias to fix API logit bias#5391
Merged
oobabooga merged 27 commits intooobabooga:devfrom Jan 29, 2024
Merged
Remove tiktoken from logit bias to fix API logit bias#5391oobabooga merged 27 commits intooobabooga:devfrom
oobabooga merged 27 commits intooobabooga:devfrom
Conversation
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch
Merge dev branch (oobabooga#5257)
Merge dev branch
Merge dev branch
Merge dev branch
Remove tiktoken
Contributor
Author
|
edit: target to dev not main |
Owner
|
I think that removing tiktoken is a good thing for consistency. Have you made tests over API to validate that the logit bias is working as intended? If so the PR can be merged. |
Contributor
Author
|
Yes.. I tested it first with silly tavern. Definitely can remove a token with negative and make the token the only reply with positive. |
Owner
|
Looks good then |
PoetOnTheRun
pushed a commit
to PoetOnTheRun/text-generation-webui
that referenced
this pull request
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
TikToken is not used in other parts of the file, they are commented out. The model parameter is not required for internal tokenization. The models tiktoken expects are only served by openAI. If there is another reason to keep this please please comment. Since the previous patch wasn't clean by skipping via exception, perhaps this is better. Otherwise we cannot use logit bias over the API at all and it is a broken feature.
fixes: #5232