Skip to content

Add dynamic_temperature_low parameter#5198

Merged
oobabooga merged 4 commits intodevfrom
dynamic_temperature_low
Jan 7, 2024
Merged

Add dynamic_temperature_low parameter#5198
oobabooga merged 4 commits intodevfrom
dynamic_temperature_low

Conversation

@oobabooga
Copy link
Copy Markdown
Owner

@oobabooga oobabooga commented Jan 7, 2024

That's a follow-up to #5174 that makes the parameters more intuitive to use.

@BadisG
Copy link
Copy Markdown
Contributor

BadisG commented Jan 8, 2024

That's better, I appreciate the modification, imo I would've added a "dynamic temp high" so that the temperature itself is separated from this sampler (and it makes the UI a bit more intuitive, because you can't guess in first glance that temperature must be used as the max if you have no idea what a dynamic temp actually is) but I'm just being picky there ^^'

@kalomaze
Copy link
Copy Markdown
Contributor

kalomaze commented Jan 9, 2024

I'm sorry but the inconsistency across backends with how it is being implemented is really bothersome and makes it difficult for new users to even understand what the options are doing.

  • Koboldcpp is using just the range value in the experimental branch where it's been merged.
  • Here, your "regular temp" is used as the max possible Temperature. This is not obvious to new users who want to use DynaTemp, and having an extra dynatemp low hyperparameter _with a boolean to turn it on but still relying on the regular Temperature, to me, is inherently contradictory design.
  • If Dynamic Temperature is turned on, it might as well have two values for Minimum Temperature and Maximum Temperature, in order to completely divorce it from the regular Temperature.

What I want to standardize, at least from a frontend standpoint, hopefully:

  • Dynamic Temperature on/off setting
  • Minimum Temperature
  • Maximum Temperature

@BadisG
Copy link
Copy Markdown
Contributor

BadisG commented Jan 9, 2024

What I want to standardize, at least from a frontend standpoint, hopefully:

Dynamic Temperature on/off setting
Minimum Temperature
Maximum Temperature

@kalomaze he did it.
#5209

@oobabooga oobabooga deleted the dynamic_temperature_low branch January 9, 2024 02:48
PoetOnTheRun pushed a commit to PoetOnTheRun/text-generation-webui that referenced this pull request Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants