Use require() and browserify to organize dependencies and compilation. #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Let's give this another go... see #30 (comment))
This is a squashed cherry-pick of the first three commits of
#30, plus a small fix to the Timers module,
and slight updates to package.json and .npmignore.
The reason this isn't in separate commits is that the first three didn't work
individually. Squashing them together allows:
the automated tests to pass
a Node.js phone to be tested as follows:
npm install ws
node
WebSocket = require('ws')
var SIP = require('./.');
var ua = new SIP.UA({traceSip: true});
ua.message('[email protected]', 'Node says hi!');
For completeness, unsquashed commit messages are listed below:
1: Use require() and browserify to organize dependencies and compilation.
Conflicts:
Gruntfile.js
package.json
src/tail.js
Cherry-picked from:
josephfrazier@df33833
2: Clean up module dependencies.
Conflicts:
src/Timers.js
src/WebRTC.js
Cherry-picked from:
josephfrazier@9af96e9
3: Grammar module depends on SIP
Cherry-picked from:
josephfrazier@3e0c165
4: Timers module depends on window
See:
josephfrazier@2510347#diff-7f75ad1c8b0a978a180c50fe4c649e8bL25
5: package.json: set "main": "src/SIP.js"
Now that our src/ files are modules, we don't have to compile the module before
require()ing it.
6: .npmignore dist/sip*
There's no need for
npm installto bring in dist/ files. Leave that to bower.