Release 0.6.0 #59
Merged
Release 0.6.0 #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly the request.
Fixed a small problem where the search/replace regex to alter the sdp from sendrecv to sendonly or inactive was missing the newlines.
Fixed sendrecv regex issue
Also fix related Session.js logic, testing Conflicts: src/Session.js
Use PEG.js 0.8.0.
…red as rel100 required
Move browser prefixing into SIP.Utils
This reverts commit 6319282.
WebRTC.MediaHandler: peerConnection.onaddstream emits 'addStream' event
InviteServerContext fires Accepted when accepting fixes #15
fixes #48 To migrate applications, replace: session.on('referred', referFollowed); with: session.on('refer', session.followRefer(referFollowed));
This argument: * was removed from the current draft WebRTC spec: https://goo.gl/yqgml3 (no. 16) * was optional before it was removed: https://goo.gl/6n5v0I * doesn't seem useful to applications Also, this facilitates compatibility with WebRTC plugins (such as Temasys's) that cause an error if the argument is passed.
Session: on re-INVITE, send 488 instead of calling this.receiveReinvite fixes #19
WebRTC.MediaHandler: don't pass constraints to peerConnection.addStream
src/Session.js: Replace 'referred' event with 'refer' handler helper
This provides basic compatibility with the Temasys WebRTC plugin.
When sending SIP messages with "special characters" e.g. "äöü", the "Content-Length" of the body needs to be correct. (Content-length mis-match). Before this change, the byte count was wrong e.g. "ä" => 1 instead of 2 I wrote a couple of examples in "SpecSIPMessage" and double checked them with MRI (Ruby 2.0.0). Thanks to [Tgr](http://stackoverflow.com/a/2848483/980524)
Fixes the way utf8 string length is counted.
I noticed some specs in SpecSIPMessage were not yet implemented.
They assert what was written in the corresponding 'it' blocks, with one
exception:
if a header is neither in headers nor extraHeaders,
.getHeaders()
returns an empty array, but the spec said it should return 'undefined'.
I think an emtpy array makes more sense though. Let me know if you
disagree and I'll change it.
Complete the SIP-Message specs.
also, Dialog.sendRequest returns the sent request
This disobeys an NPM tip: https://www.npmjs.org/doc/package.json.html#name but avoids naming conflicts with https://www.npmjs.org/package/sip
git add -f dist/sip.js dist/sip.min.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with
You can also use
bower:cd /tmp rm -rf bower_components bower install onsip/SIP.js#prerelease-0.6.0