Skip to content

Re-enable receiving reINVITEs #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2015
Merged

Re-enable receiving reINVITEs #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,9 +663,7 @@ Session.prototype = {
case SIP.C.INVITE:
if(this.status === C.STATUS_CONFIRMED) {
this.logger.log('re-INVITE received');
// Switch these two lines to try re-INVITEs:
//this.receiveReinvite(request);
request.reply(488, null, ['Warning: 399 sipjs "Cannot update media description"']);
this.receiveReinvite(request);
}
break;
case SIP.C.INFO:
Expand Down
4 changes: 2 additions & 2 deletions test/spec/SpecSession.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1595,7 +1595,7 @@ describe('InviteServerContext', function() {
});

describe('method is INVITE', function() {
xit('calls receiveReinvite', function() {
it('calls receiveReinvite', function() {
InviteServerContext.status = 12;
req = SIP.Parser.parseMessage([
'INVITE sip:[email protected];transport=ws;aor=james%40onsnip.onsip.com SIP/2.0',
Expand Down Expand Up @@ -2459,7 +2459,7 @@ describe('InviteClientContext', function() {
expect(InviteClientContext.terminated).toHaveBeenCalledWith(request, SIP.C.causes.BYE);
});

xit('logs and calls receiveReinvite if request method is INVITE', function() {
it('logs and calls receiveReinvite if request method is INVITE', function() {
InviteClientContext.status = 12;
request.method = SIP.C.INVITE;

Expand Down