Skip to content

Propagate signals to child processes #1565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −1
Open

Propagate signals to child processes #1565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion internal/interrupt_handler/interrupt_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,8 +129,9 @@ func (handler *InterruptHandler) registerForInterrupts() {
var interruptCause InterruptCause
for {
select {
case <-signalChannel:
case signal := <-signalChannel:
interruptCause = InterruptCauseSignal
signalChildren(signal)
case <-abortChannel:
interruptCause = InterruptCauseAbortByOtherProcess
case <-handler.stop:
Expand Down Expand Up @@ -158,6 +159,19 @@ func (handler *InterruptHandler) registerForInterrupts() {
}(abortChannel)
}

// Propagate the signal to all child processes.
func signalChildren(osSignal os.Signal) {
sysSignal := syscall.SIGTERM
if osSignal == os.Interrupt {
sysSignal = syscall.SIGINT
}
// Minus sign is for PGID rather than PID.
err := syscall.Kill(-syscall.Getpid(), sysSignal)
if err != nil {
os.Stderr.WriteString("Failed to signal child processes: " + err.Error() + "\n")
}
}

func (handler *InterruptHandler) Status() InterruptStatus {
handler.lock.Lock()
status := InterruptStatus{
Expand Down