Skip to content

Adding support for iOS Live Activity push notifications#70

Merged
Ariandr merged 1 commit intoonmyway133:masterfrom
mvandervelden:master
Sep 22, 2022
Merged

Adding support for iOS Live Activity push notifications#70
Ariandr merged 1 commit intoonmyway133:masterfrom
mvandervelden:master

Conversation

@mvandervelden
Copy link
Copy Markdown
Contributor

Background

As mentioned in these Apple Docs about the upcoming Live Activities feature. This feature will support using APNs push notifications, for which some specific headers are required:

  • The apns-topic header should have the format <your bundleID>.push-type.liveactivity
  • The apns-push-type header should be liveactivity.

This PR

With this change, the Push Notifications app should support this new type of notifications, if users provide the correct apns-topic as bundleId (<your bundleID>.push-type.liveactivity).

Let me know if anything in the PR requires changing. This set up seems to work for me locally.

@Ariandr
Copy link
Copy Markdown
Collaborator

Ariandr commented Sep 22, 2022

Hi @mvandervelden
Thank you for this PR.

The code change is straightforward, so If you tested and it works, I'll create a new release with this change.

Copy link
Copy Markdown
Collaborator

@Ariandr Ariandr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ariandr Ariandr merged commit 0175151 into onmyway133:master Sep 22, 2022
@mvandervelden
Copy link
Copy Markdown
Contributor Author

@Ariandr thanks for approving and merging! 🙇

@Ariandr
Copy link
Copy Markdown
Collaborator

Ariandr commented Sep 27, 2022

@mvandervelden always happy to see people contributing❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants