Skip to content

Fix GRPC Retry Configuration #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jribbink merged 6 commits into from
Nov 18, 2025
+10 −17
Merged

Fix GRPC Retry Configuration #916

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ba67ec4
fix retry config
jribbink Nov 18, 2025
6446091
tidy
jribbink Nov 18, 2025
ebe7780
change error
jribbink Nov 18, 2025
fe829c4
fix retry
jribbink Nov 18, 2025
c3a6cfe
change name
jribbink Nov 18, 2025
c77f72b
change number
jribbink Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions utils/grpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,23 +19,17 @@
package utils

// DefaultGRPCServiceConfig provides automatic retry configuration for transient gRPC errors.
// This config is applied to all remote gRPC connections to handle network flakiness in CI
// and other environments.
//
// Retries on:
// - UNAVAILABLE: Service temporarily unavailable (e.g., node restarting)
// - RESOURCE_EXHAUSTED: Rate limiting from remote node
// - UNKNOWN: Connection failures, DNS issues, and other network errors
//
// Note: We only retry on clearly transient network/availability errors.
// We do NOT retry on INTERNAL (programming errors), ABORTED (conflicts),
// or DEADLINE_EXCEEDED (to avoid cascading failures on slow services).
// Retries are applied to AccessAPI and ExecutionDataAPI to handle network issues and
// rate limiting from remote access nodes.
const DefaultGRPCServiceConfig = `{
"methodConfig": [{
"name": [{"service": ""}],
"name": [
{"service": "flow.access.AccessAPI"},
{"service": "flow.executiondata.ExecutionDataAPI"}
],
"retryPolicy": {
"maxAttempts": 5,
"initialBackoff": "0.1s",
"maxAttempts": 10,
"initialBackoff": "1s",
"maxBackoff": "30s",
"backoffMultiplier": 2,
"retryableStatusCodes": ["UNAVAILABLE", "RESOURCE_EXHAUSTED", "UNKNOWN"]
Expand Down
Loading