Skip to content

Implement missing GetTransaction(Result) queries for system transactions #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jribbink merged 3 commits into from
Nov 13, 2025
Merged

Implement missing GetTransaction(Result) queries for system transactions #912

jribbink merged 3 commits into from
Nov 13, 2025

Conversation

@jribbink
Copy link
Contributor

@jribbink jribbink commented Nov 13, 2025 •
edited
Loading

Closes #886

Description

Fixes few remaining inconsistencies found in system/scheduled transactions implemetnation

  • Add support for zero system tx id for backward-compatibility

  • Implement GetTransactionResult support for system transactions

  • Fix static system transaction cache

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@jribbink jribbink force-pushed the jribbink/add-zero-id-support branch from 6d6de74 to c5a97a8 Compare November 13, 2025 23:09
@jribbink jribbink changed the title Add support for zero system tx id for backward-compatibility Implementmissing GetTransaction(Result) queries for system transactions Nov 13, 2025
@jribbink jribbink changed the title Implementmissing GetTransaction(Result) queries for system transactions Implement missing GetTransaction(Result) queries for system transactions Nov 13, 2025
@jribbink jribbink changed the title Implement missing GetTransaction(Result) queries for system transactions Implement missing GetTransaction(Result) queries for system transactions Nov 13, 2025
@jribbink jribbink merged commit 5f706c0 into master Nov 13, 2025
3 checks passed
@jribbink jribbink deleted the jribbink/add-zero-id-support branch November 13, 2025 23:45
@jribbink jribbink added the Improvement Technical work without new features, refactoring, improving tests label Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chasefleming chasefleming chasefleming approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@peterargue peterargue Awaiting requested review from peterargue peterargue is a code owner

@mfbz mfbz Awaiting requested review from mfbz mfbz is a code owner

Assignees

No one assigned

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flow transactions get-system panic

3 participants

@jribbink @chasefleming