Skip to content

Improve comment clarity for system chunk transaction index calculation #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jribbink merged 2 commits into from
Nov 10, 2025
Merged

Improve comment clarity for system chunk transaction index calculation #911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2e372a
Initial plan
Copilot Nov 10, 2025
2de65e2
Improve comment clarity for system chunk transaction index calculation
Copilot Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions emulator/blockchain.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,8 +1500,7 @@ func (b *Blockchain) commitBlock() (*flowgo.Block, error) {
scheduledTransactionIDs = scheduledTxIDs
}

// lastly we execute the system chunk transaction
// System chunk comes after all user txs and scheduled txs
// Calculate index for system chunk transaction which executes after all user and scheduled transactions
systemChunkIndex := uint32(len(transactions)) + uint32(len(systemTransactionIDs))
chunkBody, itr, err := b.executeSystemChunkTransaction(systemChunkIndex)
if err != nil {
Expand Down