Skip to content

Fix and improve computation profiling #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
turbolent merged 2 commits into from
Nov 7, 2025
Merged

Fix and improve computation profiling #904

turbolent merged 2 commits into from
Nov 7, 2025

Conversation

@turbolent
Copy link
Member

@turbolent turbolent commented Nov 7, 2025 •
edited
Loading

Description

  • Fix setting execution effort weights
  • Improve computation profile endpoint:
    • Suggest filename with .pprof suffix
    • Handle the case where profiling is disabled
    • Add .cdc suffix to filenames, so source lookup works

For contributor use:

  • Targeted PR against master branch
  • Linked to GitHub issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the GitHub PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Nov 7, 2025
@turbolent turbolent added Improvement Technical work without new features, refactoring, improving tests Bugfix labels Nov 7, 2025
@turbolent turbolent force-pushed the bastian/fix-computation-profiling branch from 3d71145 to 9cb5376 Compare November 7, 2025 01:08
@turbolent turbolent merged commit c5cce13 into master Nov 7, 2025
3 checks passed
@turbolent turbolent deleted the bastian/fix-computation-profiling branch November 7, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jribbink jribbink jribbink approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@peterargue peterargue Awaiting requested review from peterargue peterargue is a code owner

@mfbz mfbz Awaiting requested review from mfbz mfbz is a code owner

Assignees

@turbolent turbolent

Labels

Bugfix Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turbolent @jribbink