Automatically commit reference block after fork mode initialization #898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fork mode is initialized, the emulator now automatically commits an initial empty block to provide a valid reference block ID for transactions. This eliminates the need for users to manually call ExecuteAndCommitBlock() before submitting transactions. Previously, fork mode would initialize but leave the emulator in a state where it couldn't accept transactions until a reference block was manually committed. Tests had to work around this by explicitly committing a block. Changes: - Auto-commit initial reference block in NewEmulatorServer when ForkHost is set - Remove manual workaround from fork integration tests - Add logging for the committed reference block Fixes the issue where forked emulators were not immediately ready to accept transactions.
jribbink
requested review from
chasefleming,
janezpodhostnik,
mfbz and
peterargue
as code owners
mfbz
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #899
Description
When fork mode is initialized, the emulator now automatically commits an initial empty block to provide a valid reference block ID for transactions. This eliminates the need for users to manually call ExecuteAndCommitBlock() before submitting transactions.
Previously, fork mode would initialize but leave the emulator in a state where it couldn't accept transactions until a reference block was manually committed. Tests had to work around this by explicitly committing a block.
Changes:
Fixes the issue where forked emulators were not immediately ready to accept transactions.
For contributor use:
masterbranchFiles changedin the GitHub PR explorer