Update the latest Scheduled Transactions API changes #894
Conversation
bjartek
requested review from
chasefleming,
janezpodhostnik,
jribbink,
mfbz and
peterargue
as code owners
|
Any update on this one? |
jribbink
changed the title
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
Hey @bjartek , sorry about the delay. I've added the additional remaining changes for the Scheduled Transactions API to this PR. Does it look good to you? |
|
I just ran this through the same FCL integration test suite that I tested @peterargue's original flow-go changes against and everything worked. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the emulator to support scheduled transactions API by storing system transactions per block and providing retrieval methods via block ID and scheduled transaction ID. The implementation creates a global index mapping scheduled transaction IDs to their containing blocks.
Key Changes:
- Added
CollectionIDfield to transaction results to track which collection contains each transaction - Implemented system transaction storage and retrieval methods including scheduled transaction support
- Updated test expectations to account for system transactions (system chunk and EVM) included in block transaction counts
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| types/result.go | Added CollectionID field to StorableTransactionResult |
| storage/store.go | Added system transaction storage, scheduled transaction indexing methods, and SystemTransactions type |
| storage/store_test.go | Added comprehensive tests for scheduled transaction indexing |
| storage/sqlite/createTables.sql | Created database tables for system transactions and scheduled transaction index |
| storage/memstore/memstore.go | Implemented in-memory storage for system transactions and scheduled transaction index |
| storage/encoding.go | Added encoding/decoding functions for SystemTransactions |
| storage/mocks/store.go | Updated mock store with new method signatures |
| emulator/blockchain.go | Implemented system and scheduled transaction retrieval methods, updated block commit to store system transactions |
| emulator/transaction_test.go | Updated test expectations to account for system transactions in block counts |
| emulator/system_transaction_test.go | Added new tests for system transaction retrieval |
| emulator/emulator.go | Added interface methods for system and scheduled transaction access |
| emulator/mocks/emulator.go | Updated emulator mocks with new methods |
| convert/emu.go | Added collectionID parameter to ToStorableResult function |
| adapters/access.go | Implemented system and scheduled transaction access methods |
| internal/mocks/access.go | Added mocks for scheduled transaction access methods |
| go.mod | Updated flow-go and protobuf dependencies |
| storage/checkpoint/checkpoint.go | Updated CommitBlock call with nil system transactions |
| adapters/streaming_integration_test.go | Removed trailing whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
|
was going to take a look at this now and see that it has been merged, i still struggle with migraines so energy comes sporadically |
No worries, I think it should be good, just wanted to double check though 👍 |
4 participants
Closes #887
Description
Trying to store system transactions for each blockID and then fetching them from the transaction/transactionResult store when needed.
For contributor use:
masterbranchFiles changedin the GitHub PR explorer