-
Notifications
You must be signed in to change notification settings - Fork 0
Add NAV-based balance using convertToAssets instead of AMM quote #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nialexsan
merged 4 commits into
main
from
loic/pkm-385-add-nav-based-balance-to-yield-vault-strategies
Mar 10, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
36158c3
add getNAVBalance to YieldVault, implementation in PMStrategiesV1
loic1 1285bef
update FlowALP submodule
loic1 c252eb4
revert submodule refactir
nialexsan aafc519
Merge remote-tracking branch 'origin/main' into loic/pkm-385-add-nav-…
nialexsan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navBalanceshould mean mark-to-market position value, not “safe-to-withdraw now”.Right now the base
Strategy.navBalance()default delegates toavailableBalance(). For strategies that don’t override it, this makesnavBalancehealth/withdrawability-constrained (as it depends on FlowALP health considerations), which is a different concept from NAV and can understate value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liobrasil Good catch. My intention was that this comment would clarify what
navBalancerepresents:Returns the NAV-based balance of the given token. Defaults to availableBalance(); strategies backed by ERC-4626 vaults should override to return convertToAssets(shares) instead of an AMM quote.Does updating the method definition to
access(all) fun navBalance(ofToken: Type): UFix64? { return nil }address your concern? If not, do you have any suggestions? The contract was already updated to mainnet to unblock enter strategy transaction failures in peak money.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @nialexsan for vis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry @loic1 just seeing this here !
I've a PR to make it returns
nilhere : https://github.com/onflow/FlowYieldVaults/pull/194/changes#diff-9afe2a41d5d1ce1e01ebaa192895085437943efc8ab1eee80cca42eb547b322bR96